This is an automated email from the ASF dual-hosted git repository. ppkarwasz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/logging-flume-legacy.git
commit 9bf07a0e5d6883ea5c43d47241aaa2e87a10e529 Author: Ferenc Szabo <[email protected]> AuthorDate: Thu Nov 8 18:11:27 2018 +0100 FLUME-3280 Improve maven build to help code reviews by adding static … …code analyzer Adding spotbugs, pmd to the build. moving flume-checkstyle to a new build-support module that contains any future build tool configuration. Fixed some trivial checkstyle issues. Updated apache parent version and maven plugin versions. Added maxAllowedViolations so this commit could contain only the new checks and not any code change. Did some cleanup in the pom files. This closes #232 Reviewers: Peter Turcsanyi, Endre Major (Ferenc Szabo via Ferenc Szabo) --- flume-ng-log4jappender/pom.xml | 11 ++++++----- .../apache/flume/clients/log4jappender/TestLog4jAppender.java | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/flume-ng-log4jappender/pom.xml b/flume-ng-log4jappender/pom.xml index 4d25c2b..8fc57af 100644 --- a/flume-ng-log4jappender/pom.xml +++ b/flume-ng-log4jappender/pom.xml @@ -29,13 +29,14 @@ limitations under the License. <artifactId>flume-ng-log4jappender</artifactId> <name>Flume NG Log4j Appender</name> + <properties> + <!-- TODO fix spotbugs/pmd violations --> + <spotbugs.maxAllowedViolations>2</spotbugs.maxAllowedViolations> + <pmd.maxAllowedViolations>1</pmd.maxAllowedViolations> + </properties> + <build> <plugins> - <plugin> - <groupId>org.apache.rat</groupId> - <artifactId>apache-rat-plugin</artifactId> - </plugin> - <plugin> <artifactId>maven-assembly-plugin</artifactId> <configuration> diff --git a/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java b/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java index 3f8ba37..891cb66 100644 --- a/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java +++ b/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java @@ -22,7 +22,6 @@ import java.io.File; import java.io.FileReader; import java.io.IOException; import java.net.ServerSocket; -import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.Map;
