Lucene.Net.Codecs.Bloom.MurmurHash2 refactor: Changed uint parameter in Hash function to int, added unchecked cast to overflow the constant, and removed unnecessary array cast
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/fd578526 Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/fd578526 Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/fd578526 Branch: refs/heads/api-work Commit: fd5785269554a007ddedb5a28defae7687f4d56e Parents: e106720 Author: Shad Storhaug <[email protected]> Authored: Sun Jan 29 17:07:33 2017 +0700 Committer: Shad Storhaug <[email protected]> Committed: Sun Jan 29 17:10:26 2017 +0700 ---------------------------------------------------------------------- src/Lucene.Net.Codecs/Bloom/MurmurHash2.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/fd578526/src/Lucene.Net.Codecs/Bloom/MurmurHash2.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Codecs/Bloom/MurmurHash2.cs b/src/Lucene.Net.Codecs/Bloom/MurmurHash2.cs index b638e24..9992971 100644 --- a/src/Lucene.Net.Codecs/Bloom/MurmurHash2.cs +++ b/src/Lucene.Net.Codecs/Bloom/MurmurHash2.cs @@ -42,11 +42,11 @@ namespace Lucene.Net.Codecs.Bloom { } - public static int Hash(byte[] data, uint seed, int offset, int len) // LUCENENET TODO: Change to int + public static int Hash(byte[] data, int seed, int offset, int len) { int m = 0x5bd1e995; int r = 24; - int h = (int)(seed ^ (long)len); + int h = (int)(((uint)seed) ^ (long)len); // LUCENENET NOTE: Need to convert seed to uint (since the constant was a uint) int len_4 = len >> 2; for (int i = 0; i < len_4; i++) { @@ -97,12 +97,12 @@ namespace Lucene.Net.Codecs.Bloom /// <returns>32 bit hash of the given array</returns> public static int Hash32(byte[] data, int offset, int len) { - return Hash(data, 0x9747b28c, offset, len); + return Hash(data, unchecked((int)0x9747b28c), offset, len); } public override int Hash(BytesRef br) { - return Hash32((byte[])(Array)br.Bytes, br.Offset, br.Length); // LUCENENET TODO: remove unnecessary cast + return Hash32(br.Bytes, br.Offset, br.Length); } } }
