Lucene.Net.Core: Added TODOs about merging EquatableList<T> with ValueList<T> and fixing GetHashCode of BooleanQuery
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/f1a000de Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/f1a000de Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/f1a000de Branch: refs/heads/api-work Commit: f1a000deb71b8f92171dcc9806263671c95adfe8 Parents: aa7ddea Author: Shad Storhaug <[email protected]> Authored: Fri Mar 3 14:25:43 2017 +0700 Committer: Shad Storhaug <[email protected]> Committed: Sun Mar 5 17:08:39 2017 +0700 ---------------------------------------------------------------------- src/Lucene.Net.Core/Search/BooleanQuery.cs | 2 +- src/Lucene.Net.Core/Support/EquatableList.cs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/f1a000de/src/Lucene.Net.Core/Search/BooleanQuery.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Search/BooleanQuery.cs b/src/Lucene.Net.Core/Search/BooleanQuery.cs index 7debdff..da596e5 100644 --- a/src/Lucene.Net.Core/Search/BooleanQuery.cs +++ b/src/Lucene.Net.Core/Search/BooleanQuery.cs @@ -673,7 +673,7 @@ namespace Lucene.Net.Search /// <summary> /// Returns a hash code value for this object. </summary> - public override int GetHashCode() + public override int GetHashCode() // LUCENENET TODO: Fix hashcode logic. { return Number.SingleToInt32Bits(Boost) ^ (clauses.Count == 0 ? 0 : HashHelpers.CombineHashCodes(clauses.First().GetHashCode(), clauses.Last().GetHashCode(), clauses.Count)) + MinimumNumberShouldMatch + (disableCoord ? 17 : 0); } http://git-wip-us.apache.org/repos/asf/lucenenet/blob/f1a000de/src/Lucene.Net.Core/Support/EquatableList.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Support/EquatableList.cs b/src/Lucene.Net.Core/Support/EquatableList.cs index 99db5da..afc7c9f 100644 --- a/src/Lucene.Net.Core/Support/EquatableList.cs +++ b/src/Lucene.Net.Core/Support/EquatableList.cs @@ -31,6 +31,7 @@ namespace Lucene.Net.Support /// <see cref="IEquatable{T}"/>.</summary> /// <typeparam name="T">The type of elements in the list.</typeparam> + // LUCENENET TODO: Merge with ValueList<T> (similar functionality) public class EquatableList<T> : System.Collections.Generic.List<T>, IEquatable<System.Collections.Generic.IEnumerable<T>> {
