Lucene.Net.Core.Index.SegmentCoreReaders: Added TODO about mysterious try-catch block that swallows AccessViolationExceptions that didn't exist in Lucene.
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/72cdeed9 Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/72cdeed9 Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/72cdeed9 Branch: refs/heads/api-work Commit: 72cdeed9bb488e059994d8d7f9789cb5b0f49f40 Parents: 48fd9c4 Author: Shad Storhaug <[email protected]> Authored: Sat Mar 4 18:23:02 2017 +0700 Committer: Shad Storhaug <[email protected]> Committed: Sun Mar 5 17:08:45 2017 +0700 ---------------------------------------------------------------------- src/Lucene.Net.Core/Index/SegmentCoreReaders.cs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/72cdeed9/src/Lucene.Net.Core/Index/SegmentCoreReaders.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Index/SegmentCoreReaders.cs b/src/Lucene.Net.Core/Index/SegmentCoreReaders.cs index c9f89ad..21da711 100644 --- a/src/Lucene.Net.Core/Index/SegmentCoreReaders.cs +++ b/src/Lucene.Net.Core/Index/SegmentCoreReaders.cs @@ -163,13 +163,14 @@ namespace Lucene.Net.Index normsProducer = null; } - StoredFieldsFormat sff = si.Info.Codec.StoredFieldsFormat; + // LUCENENET TODO: Not sure why this catch block is swallowing AccessViolationException, + // because it didn't exist in Lucene. Is it really needed? #if !NETSTANDARD try { #endif - fieldsReaderOrig = sff.FieldsReader(cfsDir, si.Info, fieldInfos, context); + fieldsReaderOrig = si.Info.Codec.StoredFieldsFormat.FieldsReader(cfsDir, si.Info, fieldInfos, context); #if !NETSTANDARD } #pragma warning disable 168 @@ -178,7 +179,6 @@ namespace Lucene.Net.Index { } #endif - //FieldsReaderOrig = si.Info.Codec.StoredFieldsFormat().FieldsReader(cfsDir, si.Info, fieldInfos, context); if (fieldInfos.HasVectors) // open term vector files only as needed { @@ -293,7 +293,10 @@ namespace Lucene.Net.Index /// Returns approximate RAM bytes used </summary> public long RamBytesUsed() { - return ((normsProducer != null) ? normsProducer.RamBytesUsed() : 0) + ((fields != null) ? fields.RamBytesUsed() : 0) + ((fieldsReaderOrig != null) ? fieldsReaderOrig.RamBytesUsed() : 0) + ((termVectorsReaderOrig != null) ? termVectorsReaderOrig.RamBytesUsed() : 0); + return ((normsProducer != null) ? normsProducer.RamBytesUsed() : 0) + + ((fields != null) ? fields.RamBytesUsed() : 0) + + ((fieldsReaderOrig != null) ? fieldsReaderOrig.RamBytesUsed() : 0) + + ((termVectorsReaderOrig != null) ? termVectorsReaderOrig.RamBytesUsed() : 0); } } } \ No newline at end of file
