Added various TODOs
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/b0ec6236 Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/b0ec6236 Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/b0ec6236 Branch: refs/heads/api-work Commit: b0ec6236e23283131ec36a56d42b4d8516dbd2d5 Parents: eb1b5fc Author: Shad Storhaug <[email protected]> Authored: Fri Mar 10 17:02:03 2017 +0700 Committer: Shad Storhaug <[email protected]> Committed: Fri Mar 10 17:02:03 2017 +0700 ---------------------------------------------------------------------- src/Lucene.Net.Core/Index/AtomicReader.cs | 4 ++-- src/Lucene.Net.Core/Search/FieldCacheImpl.cs | 4 ++-- src/Lucene.Net.Core/Search/FieldValueHitQueue.cs | 4 ++-- src/Lucene.Net.Core/Search/IndexSearcher.cs | 2 +- src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b0ec6236/src/Lucene.Net.Core/Index/AtomicReader.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Index/AtomicReader.cs b/src/Lucene.Net.Core/Index/AtomicReader.cs index 24419ea..594a6d8 100644 --- a/src/Lucene.Net.Core/Index/AtomicReader.cs +++ b/src/Lucene.Net.Core/Index/AtomicReader.cs @@ -188,7 +188,7 @@ namespace Lucene.Net.Index /// <summary> /// this may return null if the field does not exist. </summary> - public Terms Terms(string field) + public Terms Terms(string field) // LUCENENET TODO: Change to GetTerms() { Fields fields = Fields; if (fields == null) @@ -203,7 +203,7 @@ namespace Lucene.Net.Index /// this will return null if either the field or /// term does not exist. </summary> /// <seealso cref= TermsEnum#docs(Bits, DocsEnum) </seealso> - public DocsEnum TermDocsEnum(Term term) + public DocsEnum TermDocsEnum(Term term) // LUCENENET TODO: Change to GetTermDocsEnum() { Debug.Assert(term.Field != null); Debug.Assert(term.Bytes != null); http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b0ec6236/src/Lucene.Net.Core/Search/FieldCacheImpl.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Search/FieldCacheImpl.cs b/src/Lucene.Net.Core/Search/FieldCacheImpl.cs index 8bd31d2..f5c0457 100644 --- a/src/Lucene.Net.Core/Search/FieldCacheImpl.cs +++ b/src/Lucene.Net.Core/Search/FieldCacheImpl.cs @@ -260,7 +260,7 @@ namespace Lucene.Net.Search object readerKey = reader.CoreCacheKey; lock (readerCache) { - innerCache = readerCache[readerKey]; + innerCache = readerCache[readerKey]; // LUCENENET TODO: Possible exception if (innerCache == null) { // First time this reader is using FieldCache @@ -437,7 +437,7 @@ namespace Lucene.Net.Search } } - protected abstract TermsEnum TermsEnum(Terms terms); + protected abstract TermsEnum TermsEnum(Terms terms); // LUCENENET TODO: Change to GetTermsEnum() protected abstract void VisitTerm(BytesRef term); http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b0ec6236/src/Lucene.Net.Core/Search/FieldValueHitQueue.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Search/FieldValueHitQueue.cs b/src/Lucene.Net.Core/Search/FieldValueHitQueue.cs index 3724a84..2e73c8a 100644 --- a/src/Lucene.Net.Core/Search/FieldValueHitQueue.cs +++ b/src/Lucene.Net.Core/Search/FieldValueHitQueue.cs @@ -84,7 +84,7 @@ namespace Lucene.Net.Search return hitA.Doc > hitB.Doc; } - public override bool LessThan(Entry a, Entry b) + public override bool LessThan(Entry a, Entry b) // LUCENENET TODO: Calls itself (remove?) { return LessThan(a, b); } @@ -129,7 +129,7 @@ namespace Lucene.Net.Search return hitA.Doc > hitB.Doc; } - public override bool LessThan(Entry a, Entry b) + public override bool LessThan(Entry a, Entry b) // LUCENENET TODO: Calls itself (remove?) { return LessThan(a, b); } http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b0ec6236/src/Lucene.Net.Core/Search/IndexSearcher.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Core/Search/IndexSearcher.cs b/src/Lucene.Net.Core/Search/IndexSearcher.cs index 814657c..1130580 100644 --- a/src/Lucene.Net.Core/Search/IndexSearcher.cs +++ b/src/Lucene.Net.Core/Search/IndexSearcher.cs @@ -549,7 +549,7 @@ namespace Lucene.Net.Search { if (sort == null) { - throw new System.NullReferenceException("Sort must not be null"); + throw new System.NullReferenceException("Sort must not be null"); // LUCENENET TODO: Should this be ArgumentNullException?? } int limit = reader.MaxDoc; http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b0ec6236/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs b/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs index 82de47b..bd661da 100644 --- a/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs +++ b/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs @@ -402,7 +402,7 @@ namespace Lucene.Net.Index w.DeleteAll(); } - public virtual DirectoryReader Reader + public virtual DirectoryReader Reader // LUCENENET TODO: Change to GetReader() { get {
