BUG: Lucene.Net.Core.Support (ValueHashSet + ValueList): Corrected GetHashSet() 
so it doesn't depend on the order of the elements


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/4ed5d336
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/4ed5d336
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/4ed5d336

Branch: refs/heads/api-work
Commit: 4ed5d336f92461db989e628ed735d712f983e7b8
Parents: 50bbf51
Author: Shad Storhaug <[email protected]>
Authored: Thu Mar 23 23:51:25 2017 +0700
Committer: Shad Storhaug <[email protected]>
Committed: Thu Mar 23 23:51:25 2017 +0700

----------------------------------------------------------------------
 src/Lucene.Net.Core/Support/ValueHashSet.cs | 2 +-
 src/Lucene.Net.Core/Support/ValueList.cs    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/4ed5d336/src/Lucene.Net.Core/Support/ValueHashSet.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Support/ValueHashSet.cs 
b/src/Lucene.Net.Core/Support/ValueHashSet.cs
index 0421fcb..6227ae7 100644
--- a/src/Lucene.Net.Core/Support/ValueHashSet.cs
+++ b/src/Lucene.Net.Core/Support/ValueHashSet.cs
@@ -62,7 +62,7 @@ namespace Lucene.Net.Support
                 T obj = i.Current;
                 if (!EqualityComparer<T>.Default.Equals(obj, default(T)))
                 {
-                    h = HashHelpers.CombineHashCodes(h, obj.GetHashCode());
+                    h += obj.GetHashCode();
                 }
             }
             return h;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/4ed5d336/src/Lucene.Net.Core/Support/ValueList.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Support/ValueList.cs 
b/src/Lucene.Net.Core/Support/ValueList.cs
index d09874e..d67ce5c 100644
--- a/src/Lucene.Net.Core/Support/ValueList.cs
+++ b/src/Lucene.Net.Core/Support/ValueList.cs
@@ -59,7 +59,7 @@ namespace Lucene.Net.Support
                 T obj = i.Current;
                 if (!EqualityComparer<T>.Default.Equals(obj, default(T)))
                 {
-                    h = HashHelpers.CombineHashCodes(h, obj.GetHashCode());
+                    h += obj.GetHashCode();
                 }
             }
             return h;

Reply via email to