Lucene.Net.Expressions: Added TODO since the documentation indicates a ParseException can be thrown but it doesn't seem possible in the code
Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/3d977cbe Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/3d977cbe Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/3d977cbe Branch: refs/heads/master Commit: 3d977cbea561e4d9596a0edff2ff872761afc334 Parents: 53ae7cd Author: Shad Storhaug <[email protected]> Authored: Thu Jul 6 05:52:22 2017 +0700 Committer: Shad Storhaug <[email protected]> Committed: Thu Jul 6 05:52:22 2017 +0700 ---------------------------------------------------------------------- src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs | 2 ++ 1 file changed, 2 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/3d977cbe/src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs b/src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs index 42578c0..c95c056 100644 --- a/src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs +++ b/src/Lucene.Net.Expressions/JS/JavascriptCompiler.cs @@ -117,6 +117,8 @@ namespace Lucene.Net.Expressions.JS /// <param name="sourceText">The expression to compile</param> /// <returns>A new compiled expression</returns> /// <exception cref="ParseException">on failure to compile</exception> + // LUCENENET TODO: ParseException not being thrown here - need to check + // where this is thrown in Java and throw the equivalent in .NET public static Expression Compile(string sourceText) { return new JavascriptCompiler(sourceText).CompileExpression();
