This is an automated email from the ASF dual-hosted git repository.
nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git
The following commit(s) were added to refs/heads/master by this push:
new 63c274c Lucene.Net.Analysis.OpenNLP: Upgraded NuGet package
dependency to OpenNLP.NET 1.9.1.1 and updated the projects to sign the
Lucene.Net.Analysis.OpenNLP and Lucene.Net.Analysis.Tests.OpenNLP assemblies.
63c274c is described below
commit 63c274cc7693db5a3b703714682fc3006e24164f
Author: Shad Storhaug <[email protected]>
AuthorDate: Tue Apr 6 01:53:35 2021 +0700
Lucene.Net.Analysis.OpenNLP: Upgraded NuGet package dependency to
OpenNLP.NET 1.9.1.1 and updated the projects to sign the
Lucene.Net.Analysis.OpenNLP and Lucene.Net.Analysis.Tests.OpenNLP assemblies.
---
build/Dependencies.props | 2 +-
.../Lucene.Net.Analysis.OpenNLP.csproj | 5 -----
.../Lucene.Net.Tests.Analysis.OpenNLP.csproj | 7 +------
.../TestOpenNLPSentenceBreakIterator.cs | 13 +------------
.../TestOpenNLPTokenizerFactory.cs | 5 -----
5 files changed, 3 insertions(+), 29 deletions(-)
diff --git a/build/Dependencies.props b/build/Dependencies.props
index 8c44eb0..c89d0e2 100644
--- a/build/Dependencies.props
+++ b/build/Dependencies.props
@@ -70,7 +70,7 @@
<NewtonsoftJsonPackageVersion>10.0.1</NewtonsoftJsonPackageVersion>
<NUnit3TestAdapterPackageVersion>3.17.0</NUnit3TestAdapterPackageVersion>
<NUnitPackageVersion>3.13.1</NUnitPackageVersion>
- <OpenNLPNETPackageVersion>1.9.1</OpenNLPNETPackageVersion>
+ <OpenNLPNETPackageVersion>1.9.1.1</OpenNLPNETPackageVersion>
<SharpZipLibPackageVersion>1.1.0</SharpZipLibPackageVersion>
<Spatial4nCorePackageVersion>0.4.1</Spatial4nCorePackageVersion>
<Spatial4nCoreNTSPackageVersion>$(Spatial4nCorePackageVersion)</Spatial4nCoreNTSPackageVersion>
diff --git a/src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj
b/src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj
index 40546e2..848d91b 100644
--- a/src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj
+++ b/src/Lucene.Net.Analysis.OpenNLP/Lucene.Net.Analysis.OpenNLP.csproj
@@ -35,11 +35,6 @@
<RootNamespace>Lucene.Net.Analysis.OpenNlp</RootNamespace>
</PropertyGroup>
- <!-- OpenNLP is not strong-named -->
- <PropertyGroup Label="Assembly Signing">
- <SignAssembly>false</SignAssembly>
- </PropertyGroup>
-
<ItemGroup>
<ProjectReference Include="..\dotnet\Lucene.Net.ICU\Lucene.Net.ICU.csproj"
/>
<ProjectReference Include="..\Lucene.Net\Lucene.Net.csproj" />
diff --git
a/src/Lucene.Net.Tests.Analysis.OpenNLP/Lucene.Net.Tests.Analysis.OpenNLP.csproj
b/src/Lucene.Net.Tests.Analysis.OpenNLP/Lucene.Net.Tests.Analysis.OpenNLP.csproj
index e906f80..eb4b023 100644
---
a/src/Lucene.Net.Tests.Analysis.OpenNLP/Lucene.Net.Tests.Analysis.OpenNLP.csproj
+++
b/src/Lucene.Net.Tests.Analysis.OpenNLP/Lucene.Net.Tests.Analysis.OpenNLP.csproj
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one
@@ -34,11 +34,6 @@
<IsPublishable Condition=" '$(TargetFramework)' == 'net48'
">true</IsPublishable>
</PropertyGroup>
- <!-- OpenNLP is not strong-named -->
- <PropertyGroup Label="Assembly Signing">
- <SignAssembly>false</SignAssembly>
- </PropertyGroup>
-
<ItemGroup>
<None Remove="en-test-chunker.bin" />
<None Remove="en-test-lemmas.dict" />
diff --git
a/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPSentenceBreakIterator.cs
b/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPSentenceBreakIterator.cs
index 7a5e17d..f5c54f5 100644
--- a/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPSentenceBreakIterator.cs
+++ b/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPSentenceBreakIterator.cs
@@ -6,7 +6,7 @@ using Lucene.Net.Analysis.Util;
using Lucene.Net.Util;
using NUnit.Framework;
using System;
-//using Assert = Lucene.Net.TestFramework.Assert;
+using Assert = Lucene.Net.TestFramework.Assert;
namespace Lucene.Net.Analysis.OpenNlp
{
@@ -239,16 +239,5 @@ namespace Lucene.Net.Analysis.OpenNlp
assertEquals(BreakIterator.Done, bi.Next(13));
assertEquals(BreakIterator.Done, bi.Next(-8));
}
-
- internal static void assertEquals(object expected, object actual)
- {
- Assert.AreEqual(expected, actual);
- }
-
- internal static void assertEquals(long expected, long actual)
- {
- Assert.AreEqual(expected, actual);
- }
-
}
}
diff --git
a/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPTokenizerFactory.cs
b/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPTokenizerFactory.cs
index 8c9d2cf..423094d 100644
--- a/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPTokenizerFactory.cs
+++ b/src/Lucene.Net.Tests.Analysis.OpenNLP/TestOpenNLPTokenizerFactory.cs
@@ -132,10 +132,5 @@ namespace Lucene.Net.Analysis.OpenNlp
ts.SetReader(new StringReader(SENTENCES));
AssertTokenStreamContents(ts, SENTENCES_punc);
}
-
- internal static void assertTrue(bool condition)
- {
- Assert.IsTrue(condition);
- }
}
}
