This is an automated email from the ASF dual-hosted git repository. nightowl888 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/lucenenet.git
commit dd7dc1822ffe7f43d0e5b764c1ce47624d324527 Author: Shad Storhaug <[email protected]> AuthorDate: Wed Dec 22 22:14:27 2021 +0700 Lucene.Net.TestFramework: Reviewed and removed some TODOs --- src/Lucene.Net.TestFramework/Analysis/BaseTokenStreamTestCase.cs | 2 +- src/Lucene.Net.TestFramework/Index/BaseStoredFieldsFormatTestCase.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Lucene.Net.TestFramework/Analysis/BaseTokenStreamTestCase.cs b/src/Lucene.Net.TestFramework/Analysis/BaseTokenStreamTestCase.cs index 3a7b7ae..456352a 100644 --- a/src/Lucene.Net.TestFramework/Analysis/BaseTokenStreamTestCase.cs +++ b/src/Lucene.Net.TestFramework/Analysis/BaseTokenStreamTestCase.cs @@ -651,7 +651,7 @@ namespace Lucene.Net.Analysis CheckRandomData(new J2N.Randomizer(seed), a, iterations, maxWordLength, useCharFilter, simple, offsetsAreCorrect, iw); success = true; } - catch (Exception e) when (e.IsException()) // LUCENENET TODO: This catch block can be removed because Rethrow.rethrow() simply does what its name says, but need to get rid of the FirstException functionality and fix ThreadJob so it re-throws ThreadInterruptedExcepetion first. + catch (Exception e) when (e.IsException()) { //Console.WriteLine("Exception in Thread: " + e); //throw; // LUCENENET: CA2200: Rethrow to preserve stack details (https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2200-rethrow-to-preserve-stack-details) diff --git a/src/Lucene.Net.TestFramework/Index/BaseStoredFieldsFormatTestCase.cs b/src/Lucene.Net.TestFramework/Index/BaseStoredFieldsFormatTestCase.cs index a94a5d4..a4a8537 100644 --- a/src/Lucene.Net.TestFramework/Index/BaseStoredFieldsFormatTestCase.cs +++ b/src/Lucene.Net.TestFramework/Index/BaseStoredFieldsFormatTestCase.cs @@ -324,7 +324,7 @@ namespace Lucene.Net.Index foreach (AtomicReaderContext ctx in r.Leaves) { - AtomicReader sub = ctx.AtomicReader; // LUCENENET TODO: Dispose() ? + AtomicReader sub = ctx.AtomicReader; FieldCache.Int32s ids = FieldCache.DEFAULT.GetInt32s(sub, "id", false); for (int docID = 0; docID < sub.NumDocs; docID++) {
