This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git


The following commit(s) were added to refs/heads/master by this push:
     new b5802f870 SWEEP: Add a nested comment explaining why this method is 
empty. Fixes #681.
b5802f870 is described below

commit b5802f870b3ea1761a00601c9abf795e886774da
Author: Shad Storhaug <[email protected]>
AuthorDate: Tue Oct 18 16:46:06 2022 +0700

    SWEEP: Add a nested comment explaining why this method is empty. Fixes #681.
---
 src/Lucene.Net.Benchmark/ByTask/Tasks/ReadTokensTask.cs     |  5 ++++-
 src/Lucene.Net.Benchmark/Support/TagSoup/PYXScanner.cs      |  1 +
 src/Lucene.Net.Benchmark/Support/TagSoup/PYXWriter.cs       | 13 +++++++++++++
 .../Taxonomy/Directory/DirectoryTaxonomyWriter.cs           |  3 ++-
 src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs   |  1 +
 src/Lucene.Net.Queries/Function/FunctionQuery.cs            |  1 +
 src/Lucene.Net.QueryParser/Classic/QueryParser.cs           |  2 ++
 .../Flexible/Standard/Parser/StandardSyntaxParser.cs        |  2 ++
 src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs   |  2 ++
 src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs     |  2 ++
 src/Lucene.Net/Analysis/Tokenizer.cs                        |  1 +
 src/Lucene.Net/Codecs/Lucene3x/Lucene3xTermVectorsReader.cs |  1 +
 src/Lucene.Net/Index/DocumentsWriterFlushControl.cs         |  7 ++++---
 src/Lucene.Net/Index/FrozenBufferedUpdates.cs               |  1 +
 src/Lucene.Net/Index/NoMergePolicy.cs                       |  2 ++
 src/Lucene.Net/Index/ParallelCompositeReader.cs             |  6 ++++--
 src/Lucene.Net/Search/IndexSearcher.cs                      |  1 +
 src/Lucene.Net/Search/MatchAllDocsQuery.cs                  |  3 ++-
 src/Lucene.Net/Support/Index/TaskMergeScheduler.cs          |  1 +
 src/Lucene.Net/Util/AttributeSource.cs                      |  1 +
 src/Lucene.Net/Util/Automaton/State.cs                      |  8 +++++---
 src/Lucene.Net/Util/InfoStream.cs                           |  1 +
 src/Lucene.Net/Util/MergedIterator.cs                       |  2 ++
 src/Lucene.Net/Util/RamUsageEstimator.cs                    |  1 +
 24 files changed, 57 insertions(+), 11 deletions(-)

diff --git a/src/Lucene.Net.Benchmark/ByTask/Tasks/ReadTokensTask.cs 
b/src/Lucene.Net.Benchmark/ByTask/Tasks/ReadTokensTask.cs
index 03665ddec..b9dbb4eea 100644
--- a/src/Lucene.Net.Benchmark/ByTask/Tasks/ReadTokensTask.cs
+++ b/src/Lucene.Net.Benchmark/ByTask/Tasks/ReadTokensTask.cs
@@ -152,7 +152,10 @@ namespace Lucene.Net.Benchmarks.ByTask.Tasks
                 }
             }
 
-            protected override void Dispose(bool disposing) { }
+            protected override void Dispose(bool disposing)
+            {
+                // LUCENENET: Intentionally blank
+            }
         }
 
         /// <summary>
diff --git a/src/Lucene.Net.Benchmark/Support/TagSoup/PYXScanner.cs 
b/src/Lucene.Net.Benchmark/Support/TagSoup/PYXScanner.cs
index 33dead841..93c75d738 100644
--- a/src/Lucene.Net.Benchmark/Support/TagSoup/PYXScanner.cs
+++ b/src/Lucene.Net.Benchmark/Support/TagSoup/PYXScanner.cs
@@ -133,6 +133,7 @@ namespace TagSoup
 
         public virtual void StartCDATA()
         {
+            // LUCENENET: Intentionally blank
         }
 
         //public static void main(string[] argv)  {
diff --git a/src/Lucene.Net.Benchmark/Support/TagSoup/PYXWriter.cs 
b/src/Lucene.Net.Benchmark/Support/TagSoup/PYXWriter.cs
index c06eefd06..def471f6a 100644
--- a/src/Lucene.Net.Benchmark/Support/TagSoup/PYXWriter.cs
+++ b/src/Lucene.Net.Benchmark/Support/TagSoup/PYXWriter.cs
@@ -71,6 +71,7 @@ namespace TagSoup
 
         public virtual void Entity(char[] buffer, int startIndex, int length)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual int GetEntity()
@@ -95,6 +96,7 @@ namespace TagSoup
 
         public virtual void Decl(char[] buffer, int startIndex, int length)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void GI(char[] buffer, int startIndex, int length)
@@ -220,6 +222,7 @@ namespace TagSoup
 
         public virtual void EndPrefixMapping(string prefix)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void IgnorableWhitespace(char[] buffer, int startIndex, 
int length)
@@ -240,14 +243,17 @@ namespace TagSoup
 
         public virtual void SetDocumentLocator(ILocator locator)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void SkippedEntity(string name)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void StartDocument()
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void StartElement(string uri, string localname, string 
qname, IAttributes atts)
@@ -283,6 +289,7 @@ namespace TagSoup
 
         public virtual void StartPrefixMapping(string prefix, string uri)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void Comment(char[] ch, int start, int length)
@@ -292,26 +299,32 @@ namespace TagSoup
 
         public virtual void EndCDATA()
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void EndDTD()
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void EndEntity(string name)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void StartCDATA()
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void StartDTD(string name, string publicId, string 
systemId)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public virtual void StartEntity(string name)
         {
+            // LUCENENET: Intentionally blank
         }
 
         // Constructor
diff --git a/src/Lucene.Net.Facet/Taxonomy/Directory/DirectoryTaxonomyWriter.cs 
b/src/Lucene.Net.Facet/Taxonomy/Directory/DirectoryTaxonomyWriter.cs
index 66f53f848..f21d8e99b 100644
--- a/src/Lucene.Net.Facet/Taxonomy/Directory/DirectoryTaxonomyWriter.cs
+++ b/src/Lucene.Net.Facet/Taxonomy/Directory/DirectoryTaxonomyWriter.cs
@@ -1085,8 +1085,9 @@ namespace Lucene.Net.Facet.Taxonomy.Directory
                 }
             }
 
-            public void AddDone() // nothing to do
+            public void AddDone()
             {
+                // nothing to do
             }
 
             public int[] GetMap()
diff --git a/src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs 
b/src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs
index 9b25b1d60..458b3b68b 100644
--- a/src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs
+++ b/src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs
@@ -266,6 +266,7 @@ namespace Lucene.Net.Facet.Taxonomy.WriterCache
 
             public void Dispose()
             {
+                // LUCENENET: Intentionally blank
             }
 
             public bool MoveNext()
diff --git a/src/Lucene.Net.Queries/Function/FunctionQuery.cs 
b/src/Lucene.Net.Queries/Function/FunctionQuery.cs
index 0e3745102..6e4035f5f 100644
--- a/src/Lucene.Net.Queries/Function/FunctionQuery.cs
+++ b/src/Lucene.Net.Queries/Function/FunctionQuery.cs
@@ -51,6 +51,7 @@ namespace Lucene.Net.Queries.Function
 
         public override void ExtractTerms(ISet<Term> terms)
         {
+            // LUCENENET: Intentionally blank
         }
 
         protected internal class FunctionWeight : Weight
diff --git a/src/Lucene.Net.QueryParser/Classic/QueryParser.cs 
b/src/Lucene.Net.QueryParser/Classic/QueryParser.cs
index a8f5fa636..cb8e859f6 100644
--- a/src/Lucene.Net.QueryParser/Classic/QueryParser.cs
+++ b/src/Lucene.Net.QueryParser/Classic/QueryParser.cs
@@ -896,11 +896,13 @@ namespace Lucene.Net.QueryParsers.Classic
         /// <summary>Enable tracing. </summary>
         public void Enable_tracing()
         {
+            // LUCENENET: Intentionally blank
         }
 
         /// <summary>Disable tracing. </summary>
         public void Disable_tracing()
         {
+            // LUCENENET: Intentionally blank
         }
 
         private void Jj_rescan_token()
diff --git 
a/src/Lucene.Net.QueryParser/Flexible/Standard/Parser/StandardSyntaxParser.cs 
b/src/Lucene.Net.QueryParser/Flexible/Standard/Parser/StandardSyntaxParser.cs
index 4421b52e3..215f6d3f7 100644
--- 
a/src/Lucene.Net.QueryParser/Flexible/Standard/Parser/StandardSyntaxParser.cs
+++ 
b/src/Lucene.Net.QueryParser/Flexible/Standard/Parser/StandardSyntaxParser.cs
@@ -1260,11 +1260,13 @@ namespace 
Lucene.Net.QueryParsers.Flexible.Standard.Parser
         /// <summary>Enable tracing.</summary>
         public void Enable_tracing()
         {
+            // LUCENENET: Intentionally blank
         }
 
         /// <summary>Disable tracing.</summary>
         public void Disable_tracing()
         {
+            // LUCENENET: Intentionally blank
         }
 
         private void Jj_rescan_token()
diff --git a/src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs 
b/src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs
index 5542c06a9..ebb35c25a 100644
--- a/src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs
+++ b/src/Lucene.Net.QueryParser/Surround/Parser/QueryParser.cs
@@ -871,11 +871,13 @@ namespace Lucene.Net.QueryParsers.Surround.Parser
         /// <summary>Enable tracing. </summary>
         public void Enable_tracing()
         {
+            // LUCENENET: Intentionally blank
         }
 
         /// <summary>Disable tracing. </summary>
         public void Disable_tracing()
         {
+            // LUCENENET: Intentionally blank
         }
 
         private void Jj_rescan_token()
diff --git a/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs 
b/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs
index 34f5fd236..783c15960 100644
--- a/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs
+++ b/src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs
@@ -200,6 +200,7 @@ namespace Lucene.Net.Index
 
                 public void Dispose()
                 {
+                    // LUCENENET: Intentionally blank
                 }
             }
         }
@@ -300,6 +301,7 @@ namespace Lucene.Net.Index
 
                 public void Dispose()
                 {
+                    // LUCENENET: Intentionally blank
                 }
             }
         }
diff --git a/src/Lucene.Net/Analysis/Tokenizer.cs 
b/src/Lucene.Net/Analysis/Tokenizer.cs
index d8f889725..b061d4710 100644
--- a/src/Lucene.Net/Analysis/Tokenizer.cs
+++ b/src/Lucene.Net/Analysis/Tokenizer.cs
@@ -137,6 +137,7 @@ namespace Lucene.Net.Analysis
 
             protected override void Dispose(bool disposing)
             {
+                // LUCENENET: Intentionally blank
             }
         }
     }
diff --git a/src/Lucene.Net/Codecs/Lucene3x/Lucene3xTermVectorsReader.cs 
b/src/Lucene.Net/Codecs/Lucene3x/Lucene3xTermVectorsReader.cs
index f549ed439..7e4c7b101 100644
--- a/src/Lucene.Net/Codecs/Lucene3x/Lucene3xTermVectorsReader.cs
+++ b/src/Lucene.Net/Codecs/Lucene3x/Lucene3xTermVectorsReader.cs
@@ -316,6 +316,7 @@ namespace Lucene.Net.Codecs.Lucene3x
 
                 public void Dispose()
                 {
+                    // LUCENENET: Intentionally blank
                 }
             }
 
diff --git a/src/Lucene.Net/Index/DocumentsWriterFlushControl.cs 
b/src/Lucene.Net/Index/DocumentsWriterFlushControl.cs
index a2c0be20c..72478bf8d 100644
--- a/src/Lucene.Net/Index/DocumentsWriterFlushControl.cs
+++ b/src/Lucene.Net/Index/DocumentsWriterFlushControl.cs
@@ -563,17 +563,17 @@ namespace Lucene.Net.Index
 
         private IEnumerator<ThreadState> GetPerThreadsIterator(int upto)
         {
-            return new IteratorAnonymousClass(this, upto);
+            return new EnumeratorAnonymousClass(this, upto);
         }
 
-        private class IteratorAnonymousClass : IEnumerator<ThreadState>
+        private class EnumeratorAnonymousClass : IEnumerator<ThreadState>
         {
             private readonly DocumentsWriterFlushControl outerInstance;
             private ThreadState current;
             private readonly int upto;
             private int i;
 
-            public IteratorAnonymousClass(DocumentsWriterFlushControl 
outerInstance, int upto)
+            public EnumeratorAnonymousClass(DocumentsWriterFlushControl 
outerInstance, int upto)
             {
                 this.outerInstance = outerInstance;
                 this.upto = upto;
@@ -584,6 +584,7 @@ namespace Lucene.Net.Index
 
             public void Dispose()
             {
+                // LUCENENET: Intentionally blank
             }
 
             object System.Collections.IEnumerator.Current => Current;
diff --git a/src/Lucene.Net/Index/FrozenBufferedUpdates.cs 
b/src/Lucene.Net/Index/FrozenBufferedUpdates.cs
index 04af265ee..68e9c8ae1 100644
--- a/src/Lucene.Net/Index/FrozenBufferedUpdates.cs
+++ b/src/Lucene.Net/Index/FrozenBufferedUpdates.cs
@@ -223,6 +223,7 @@ namespace Lucene.Net.Index
 
                 public void Dispose()
                 {
+                    // LUCENENET: Intentionally blank
                 }
             }
         }
diff --git a/src/Lucene.Net/Index/NoMergePolicy.cs 
b/src/Lucene.Net/Index/NoMergePolicy.cs
index d87a762e6..6191fcf30 100644
--- a/src/Lucene.Net/Index/NoMergePolicy.cs
+++ b/src/Lucene.Net/Index/NoMergePolicy.cs
@@ -53,6 +53,7 @@ namespace Lucene.Net.Index
 
         protected override void Dispose(bool disposing)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public override MergeSpecification FindMerges(MergeTrigger 
mergeTrigger, SegmentInfos segmentInfos)
@@ -77,6 +78,7 @@ namespace Lucene.Net.Index
 
         public override void SetIndexWriter(IndexWriter writer)
         {
+            // LUCENENET: Intentionally blank
         }
 
         protected override long Size(SegmentCommitInfo info)
diff --git a/src/Lucene.Net/Index/ParallelCompositeReader.cs 
b/src/Lucene.Net/Index/ParallelCompositeReader.cs
index 56ce19d3d..654a2ad4e 100644
--- a/src/Lucene.Net/Index/ParallelCompositeReader.cs
+++ b/src/Lucene.Net/Index/ParallelCompositeReader.cs
@@ -169,25 +169,27 @@ namespace Lucene.Net.Index
 
         private class ParallelAtomicReaderAnonymousClass : ParallelAtomicReader
         {
-            public 
ParallelAtomicReaderAnonymousClass(Lucene.Net.Index.AtomicReader[] atomicSubs, 
Lucene.Net.Index.AtomicReader[] storedSubs)
+            public ParallelAtomicReaderAnonymousClass(AtomicReader[] 
atomicSubs, AtomicReader[] storedSubs)
                 : base(true, atomicSubs, storedSubs)
             {
             }
 
             protected internal override void DoClose()
             {
+                // LUCENENET: Intentionally blank
             }
         }
 
         private class ParallelCompositeReaderAnonymousClass : 
ParallelCompositeReader
         {
-            public 
ParallelCompositeReaderAnonymousClass(Lucene.Net.Index.CompositeReader[] 
compositeSubs, Lucene.Net.Index.CompositeReader[] storedSubs)
+            public ParallelCompositeReaderAnonymousClass(CompositeReader[] 
compositeSubs, CompositeReader[] storedSubs)
                 : base(true, compositeSubs, storedSubs)
             {
             }
 
             protected internal override void DoClose()
             {
+                // LUCENENET: Intentionally blank
             }
         }
 
diff --git a/src/Lucene.Net/Search/IndexSearcher.cs 
b/src/Lucene.Net/Search/IndexSearcher.cs
index 635813318..f00a2d3ff 100644
--- a/src/Lucene.Net/Search/IndexSearcher.cs
+++ b/src/Lucene.Net/Search/IndexSearcher.cs
@@ -857,6 +857,7 @@ namespace Lucene.Net.Search
 
             public void Dispose()
             {
+                // LUCENENET: Intentionally blank
             }
 
             public void Submit(Func<T> task)
diff --git a/src/Lucene.Net/Search/MatchAllDocsQuery.cs 
b/src/Lucene.Net/Search/MatchAllDocsQuery.cs
index eda5d3e47..4e665cae2 100644
--- a/src/Lucene.Net/Search/MatchAllDocsQuery.cs
+++ b/src/Lucene.Net/Search/MatchAllDocsQuery.cs
@@ -1,4 +1,4 @@
-using Lucene.Net.Util;
+using Lucene.Net.Util;
 using System.Collections.Generic;
 using System.Text;
 
@@ -139,6 +139,7 @@ namespace Lucene.Net.Search
 
         public override void ExtractTerms(ISet<Term> terms)
         {
+            // LUCENENET: Intentionally blank
         }
 
         public override string ToString(string field)
diff --git a/src/Lucene.Net/Support/Index/TaskMergeScheduler.cs 
b/src/Lucene.Net/Support/Index/TaskMergeScheduler.cs
index 53c2f78a0..ec93e9a17 100644
--- a/src/Lucene.Net/Support/Index/TaskMergeScheduler.cs
+++ b/src/Lucene.Net/Support/Index/TaskMergeScheduler.cs
@@ -121,6 +121,7 @@ namespace Lucene.Net.Index
         /// </summary>
         public void SetMergeThreadPriority(int priority)
         {
+            // LUCENENET: Intentionally blank
         }
 
         /// <summary>
diff --git a/src/Lucene.Net/Util/AttributeSource.cs 
b/src/Lucene.Net/Util/AttributeSource.cs
index 285c5432a..25c9e0eab 100644
--- a/src/Lucene.Net/Util/AttributeSource.cs
+++ b/src/Lucene.Net/Util/AttributeSource.cs
@@ -298,6 +298,7 @@ namespace Lucene.Net.Util
 
             public void Dispose()
             {
+                // LUCENENET: Intentionally blank
             }
 
             public bool MoveNext()
diff --git a/src/Lucene.Net/Util/Automaton/State.cs 
b/src/Lucene.Net/Util/Automaton/State.cs
index 4a7e7cdfa..369d9f7fd 100644
--- a/src/Lucene.Net/Util/Automaton/State.cs
+++ b/src/Lucene.Net/Util/Automaton/State.cs
@@ -1,6 +1,7 @@
-using Lucene.Net.Diagnostics;
+using Lucene.Net.Diagnostics;
 using Lucene.Net.Support;
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
@@ -91,7 +92,7 @@ namespace Lucene.Net.Util.Automaton
                 return new TransitionsEnumerator(this);
             }
 
-            System.Collections.IEnumerator 
System.Collections.IEnumerable.GetEnumerator()
+            IEnumerator IEnumerable.GetEnumerator()
             {
                 return GetEnumerator();
             }
@@ -123,7 +124,7 @@ namespace Lucene.Net.Util.Automaton
 
                 public Transition Current => current;
 
-                object System.Collections.IEnumerator.Current => Current;
+                object IEnumerator.Current => Current;
 
                 public void Reset()
                 {
@@ -132,6 +133,7 @@ namespace Lucene.Net.Util.Automaton
 
                 public void Dispose()
                 {
+                    // LUCENENET: Intentionally blank
                 }
             }
         }
diff --git a/src/Lucene.Net/Util/InfoStream.cs 
b/src/Lucene.Net/Util/InfoStream.cs
index 243d66a9d..8134c9d23 100644
--- a/src/Lucene.Net/Util/InfoStream.cs
+++ b/src/Lucene.Net/Util/InfoStream.cs
@@ -50,6 +50,7 @@ namespace Lucene.Net.Util
 
             protected override void Dispose(bool disposing)
             {
+                // LUCENENET: Intentionally blank
             }
         }
 
diff --git a/src/Lucene.Net/Util/MergedIterator.cs 
b/src/Lucene.Net/Util/MergedIterator.cs
index 99860a073..359093802 100644
--- a/src/Lucene.Net/Util/MergedIterator.cs
+++ b/src/Lucene.Net/Util/MergedIterator.cs
@@ -114,6 +114,7 @@ namespace Lucene.Net.Util
 
         public void Dispose()
         {
+            // LUCENENET: Intentionally blank
         }
 
         private void PullTop()
@@ -276,6 +277,7 @@ namespace Lucene.Net.Util
 
         public void Dispose()
         {
+            // LUCENENET: Intentionally blank
         }
 
         private void PullTop()
diff --git a/src/Lucene.Net/Util/RamUsageEstimator.cs 
b/src/Lucene.Net/Util/RamUsageEstimator.cs
index 7732aa948..ce2dd0051 100644
--- a/src/Lucene.Net/Util/RamUsageEstimator.cs
+++ b/src/Lucene.Net/Util/RamUsageEstimator.cs
@@ -1042,6 +1042,7 @@ namespace Lucene.Net.Util
 
                 public void Dispose()
                 {
+                    // LUCENENET: Intentionally blank
                 }
             }
         }

Reply via email to