This is an automated email from the ASF dual-hosted git repository.
nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git
The following commit(s) were added to refs/heads/master by this push:
new e8c49dc51 Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Applied SOLR-9413
patch to fix the QuoteEscape() method and add tests. Fixes #660.
e8c49dc51 is described below
commit e8c49dc51abba323cd5344a151441d22e0e7d97d
Author: Shad Storhaug <[email protected]>
AuthorDate: Fri Oct 21 04:49:27 2022 +0700
Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Applied SOLR-9413 patch to fix
the QuoteEscape() method and add tests. Fixes #660.
---
src/Lucene.Net.Analysis.Kuromoji/Util/CSVUtil.cs | 2 +-
.../Util/TestCSVUtil.cs | 60 ++++++++++++++++++++++
2 files changed, 61 insertions(+), 1 deletion(-)
diff --git a/src/Lucene.Net.Analysis.Kuromoji/Util/CSVUtil.cs
b/src/Lucene.Net.Analysis.Kuromoji/Util/CSVUtil.cs
index d982a7099..0e94c321b 100644
--- a/src/Lucene.Net.Analysis.Kuromoji/Util/CSVUtil.cs
+++ b/src/Lucene.Net.Analysis.Kuromoji/Util/CSVUtil.cs
@@ -114,7 +114,7 @@ namespace Lucene.Net.Analysis.Ja.Util
if (result.IndexOf('\"') >= 0)
{
- result.Replace("\"", ESCAPED_QUOTE);
+ result = result.Replace("\"", ESCAPED_QUOTE); // LUCENENET
4.8.0: Applied SOLR-9413 (was fixed in Lucene 6.2/7.0)
}
if (result.IndexOf(COMMA) >= 0)
{
diff --git a/src/Lucene.Net.Tests.Analysis.Kuromoji/Util/TestCSVUtil.cs
b/src/Lucene.Net.Tests.Analysis.Kuromoji/Util/TestCSVUtil.cs
new file mode 100644
index 000000000..44e3e0ffd
--- /dev/null
+++ b/src/Lucene.Net.Tests.Analysis.Kuromoji/Util/TestCSVUtil.cs
@@ -0,0 +1,60 @@
+// Lucene version compatibility level 8.2.0
+using Lucene.Net.Util;
+using NUnit.Framework;
+using System;
+
+namespace Lucene.Net.Analysis.Ja.Util
+{
+ /*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+ /// <summary>
+ /// Tests for the CSVUtil class.
+ /// </summary>
+ public class TestCSVUtil : LuceneTestCase
+ {
+ [Test]
+ public void TestQuoteEscapeQuotes()
+ {
+ String input = "\"Let It Be\" is a song and album by the The
Beatles.";
+ String expectedOutput = input.Replace("\"", "\"\"");
+ ImplTestQuoteEscape(input, expectedOutput);
+ }
+
+ [Test]
+ public void TestQuoteEscapeComma()
+ {
+ String input = "To be, or not to be ...";
+ String expectedOutput = '"' + input + '"';
+ ImplTestQuoteEscape(input, expectedOutput);
+ }
+
+ [Test]
+ public void TestQuoteEscapeQuotesAndComma()
+ {
+ String input = "\"To be, or not to be ...\" is a well-known phrase
from Shakespeare's Hamlet.";
+ String expectedOutput = '"' + input.Replace("\"", "\"\"") + '"';
+ ImplTestQuoteEscape(input, expectedOutput);
+ }
+
+ private void ImplTestQuoteEscape(String input, String expectedOutput)
+ {
+ String actualOutput = CSVUtil.QuoteEscape(input);
+ assertEquals(expectedOutput, actualOutput);
+ }
+ }
+}
