Don't quote argument to Perl's 'system' function When using the multi-argument version of 'system', the shell isn't invoked and arguments must not be quoted.
Should fix CLOWNFISH-4 together with the prvious commit. Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/06eebd37 Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/06eebd37 Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/06eebd37 Branch: refs/heads/master Commit: 06eebd371e452552db2d6aa700a2472cf6cd34d7 Parents: 3b7eca2 Author: Nick Wellnhofer <[email protected]> Authored: Fri Sep 5 21:29:32 2014 +0200 Committer: Nick Wellnhofer <[email protected]> Committed: Fri Sep 5 21:32:53 2014 +0200 ---------------------------------------------------------------------- compiler/perl/lib/Clownfish/CFC/Perl/Build/Charmonic.pm | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/06eebd37/compiler/perl/lib/Clownfish/CFC/Perl/Build/Charmonic.pm ---------------------------------------------------------------------- diff --git a/compiler/perl/lib/Clownfish/CFC/Perl/Build/Charmonic.pm b/compiler/perl/lib/Clownfish/CFC/Perl/Build/Charmonic.pm index 36c0261..2e49e73 100644 --- a/compiler/perl/lib/Clownfish/CFC/Perl/Build/Charmonic.pm +++ b/compiler/perl/lib/Clownfish/CFC/Perl/Build/Charmonic.pm @@ -76,7 +76,7 @@ sub ACTION_charmony { # Prepare arguments to charmonizer. my @command = ( $CHARMONIZER_EXE_PATH, - '--cc=' . _quotify( $self->config('cc') ), + '--cc=' . $self->config('cc'), '--enable-c', '--enable-perl', ); @@ -108,13 +108,6 @@ sub charmony { return; } -sub _quotify { - my $string = shift; - $string =~ s/\\/\\\\/g; - $string =~ s/"/\\"/g; - return $string =~ /\s/ ? qq|"$string"| : $string; -} - 1; __END__
