Repository: madlib Updated Branches: refs/heads/master cefd15eac -> d0ad93d26
APSP: Add newline at end of file JIRA: MADLIB-1191 PGXN install requires concatenating all SQL_IN files into one big SQL file. In most cases, the last line of a SQL file is a single-line comment and the first line is a multi-line comment. One particular file (apsp.sql_in) did not have a newline at EOF, leading to the single-line comment masking the start of the multi-line comment of the next file. This eventually led to an invalid concatenated SQL file. Lesson of the day: Always add newline at end of file Project: http://git-wip-us.apache.org/repos/asf/madlib/repo Commit: http://git-wip-us.apache.org/repos/asf/madlib/commit/4a5dbe12 Tree: http://git-wip-us.apache.org/repos/asf/madlib/tree/4a5dbe12 Diff: http://git-wip-us.apache.org/repos/asf/madlib/diff/4a5dbe12 Branch: refs/heads/master Commit: 4a5dbe124071e7da9a1b1a48b7a6000cd6d34c53 Parents: cefd15e Author: Rahul Iyer <[email protected]> Authored: Mon Dec 18 15:24:14 2017 -0800 Committer: Rahul Iyer <[email protected]> Committed: Mon Dec 18 15:24:14 2017 -0800 ---------------------------------------------------------------------- src/ports/postgres/modules/graph/apsp.sql_in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/madlib/blob/4a5dbe12/src/ports/postgres/modules/graph/apsp.sql_in ---------------------------------------------------------------------- diff --git a/src/ports/postgres/modules/graph/apsp.sql_in b/src/ports/postgres/modules/graph/apsp.sql_in index 637afdf..c7bf210 100644 --- a/src/ports/postgres/modules/graph/apsp.sql_in +++ b/src/ports/postgres/modules/graph/apsp.sql_in @@ -48,11 +48,11 @@ weights of the path edges is minimized. @warning APSP is an expensive algorithm for run-time because it finds the shortest path between all nodes -in the graph. It is recommended that you start with a -small graph to get a sense of run-time for your use case, -then increase size carefully from there. The worst case run-time -for this implementation is O(V^2 * E) where V is the -number of vertices and E is the number of edges. In +in the graph. It is recommended that you start with a +small graph to get a sense of run-time for your use case, +then increase size carefully from there. The worst case run-time +for this implementation is O(V^2 * E) where V is the +number of vertices and E is the number of edges. In practice, run-time will be generally be much less than this, but it depends on the graph. @@ -435,4 +435,4 @@ RETURNS VARCHAR AS $$ SELECT MADLIB_SCHEMA.graph_apsp(''); $$ LANGUAGE sql IMMUTABLE m4_ifdef(`\_\_HAS_FUNCTION_PROPERTIES\_\_', `CONTAINS SQL', `'); --------------------------------------------------------------------------------- \ No newline at end of file +--------------------------------------------------------------------------------
