Repository: madlib
Updated Branches:
  refs/heads/master 47eefc1c9 -> 3c443e14f


RF: Comment out assert in flaky install check query

JIRA: MADLIB-1225

The variable importance computation involves randomization inherently.
So it is hard to reproduce this error consistently. This commit comments
out the assert for now (the failure rate was around 4.3%, when tested over
600 runs).

Closes #258


Project: http://git-wip-us.apache.org/repos/asf/madlib/repo
Commit: http://git-wip-us.apache.org/repos/asf/madlib/commit/3c443e14
Tree: http://git-wip-us.apache.org/repos/asf/madlib/tree/3c443e14
Diff: http://git-wip-us.apache.org/repos/asf/madlib/diff/3c443e14

Branch: refs/heads/master
Commit: 3c443e14f4054b2aa1ba9e7f432d120e68122c5f
Parents: 47eefc1
Author: Nandish Jayaram <njaya...@apache.org>
Authored: Fri Apr 6 17:16:17 2018 -0700
Committer: Nandish Jayaram <njaya...@apache.org>
Committed: Tue Apr 10 13:48:55 2018 -0700

----------------------------------------------------------------------
 .../test/random_forest.sql_in                       | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/madlib/blob/3c443e14/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in
----------------------------------------------------------------------
diff --git 
a/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in 
b/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in
index 6ab00a7..08d97d0 100644
--- 
a/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in
+++ 
b/src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in
@@ -146,10 +146,10 @@ SELECT forest_train(
 \x on
 SELECT * from train_output_summary;
 SELECT * from train_output_group;
-SELECT
-    assert(cat_var_importance[1] > con_var_importance[1], 'class should be 
important!'),
-    assert(cat_var_importance[1] > cat_var_importance[2], 'class should be 
important!')
-FROM train_output_group;
+-- SELECT
+--     assert(cat_var_importance[1] > con_var_importance[1], 'class should be 
important!'),
+--     assert(cat_var_importance[1] > cat_var_importance[2], 'class should be 
important!')
+-- FROM train_output_group;
 
 -------------------------------------------------------------------------
 -- regression - using y to predict y for the sake of testing variable 
importance
@@ -178,10 +178,10 @@ SELECT forest_train(
 SELECT * from train_output_summary;
 SELECT * from train_output_group;
 SELECT assert(oob_error < 100.0, 'oob_error is larger than 100.0!') FROM 
train_output_group;
-SELECT
-    assert(con_var_importance[1] > cat_var_importance[1], 'temperature should 
be important!'),
-    assert(con_var_importance[1] > cat_var_importance[2], 'temperature should 
be important!')
-FROM train_output_group;
+-- SELECT
+--     assert(con_var_importance[1] > cat_var_importance[1], 'temperature 
should be important!'),
+--     assert(con_var_importance[1] > cat_var_importance[2], 'temperature 
should be important!')
+-- FROM train_output_group;
 
 ----------------------------------------------------------------------------
 -- classification without grouping and set importance as FALSE

Reply via email to