Author: gsingers
Date: Sat Nov 12 08:15:20 2011
New Revision: 1201222
URL: http://svn.apache.org/viewvc?rev=1201222&view=rev
Log:
MAHOUT-881: add a unit test for TopItems also fix minor code formatting issue
Added:
mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/TopItemsTest.java
Modified:
mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
Modified:
mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
URL:
http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java?rev=1201222&r1=1201221&r2=1201222&view=diff
==============================================================================
---
mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
(original)
+++
mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/TopItems.java
Sat Nov 12 08:15:20 2011
@@ -174,7 +174,7 @@ public final class TopItems {
return result;
}
- public static
List<GenericUserSimilarity.UserUserSimilarity>getTopUserUserSimilarities(
+ public static List<GenericUserSimilarity.UserUserSimilarity>
getTopUserUserSimilarities(
int howMany, Iterator<GenericUserSimilarity.UserUserSimilarity>
allSimilarities) {
Queue<GenericUserSimilarity.UserUserSimilarity> topSimilarities
Added:
mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/TopItemsTest.java
URL:
http://svn.apache.org/viewvc/mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/TopItemsTest.java?rev=1201222&view=auto
==============================================================================
---
mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/TopItemsTest.java
(added)
+++
mahout/trunk/core/src/test/java/org/apache/mahout/cf/taste/impl/recommender/TopItemsTest.java
Sat Nov 12 08:15:20 2011
@@ -0,0 +1,160 @@
+package org.apache.mahout.cf.taste.impl.recommender;
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+import org.apache.mahout.cf.taste.common.TasteException;
+import org.apache.mahout.cf.taste.impl.TasteTestCase;
+import org.apache.mahout.cf.taste.impl.common.LongPrimitiveArrayIterator;
+import org.apache.mahout.cf.taste.impl.common.LongPrimitiveIterator;
+import org.apache.mahout.cf.taste.impl.similarity.GenericItemSimilarity;
+import org.apache.mahout.cf.taste.impl.similarity.GenericUserSimilarity;
+import org.apache.mahout.cf.taste.recommender.RecommendedItem;
+import org.apache.mahout.common.RandomUtils;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+/**
+ *
+ *
+ **/
+public class TopItemsTest extends TasteTestCase {
+
+ @Test
+ public void testTopItems() throws Exception {
+ long[] ids = new long[100];
+ for (int i = 0; i < 100; i++) {
+ ids[i] = i;
+ }
+ LongPrimitiveIterator possibleItemIds = new
LongPrimitiveArrayIterator(ids);
+ TopItems.Estimator<Long> estimator = new TopItems.Estimator<Long>() {
+ @Override
+ public double estimate(Long thing) throws TasteException {
+ return thing;
+ }
+ };
+ List<RecommendedItem> topItems = TopItems.getTopItems(10, possibleItemIds,
null, estimator);
+ int gold = 99;
+ for (RecommendedItem topItem : topItems) {
+ assertEquals(gold, topItem.getItemID());
+ assertEquals(gold--, topItem.getValue(), 0.01);
+ }
+ }
+
+ @Test
+ public void testTopItemsRandom() throws Exception {
+ long[] ids = new long[100];
+ for (int i = 0; i < 100; i++) {
+ ids[i] = i;
+ }
+ LongPrimitiveIterator possibleItemIds = new
LongPrimitiveArrayIterator(ids);
+ final Random random = RandomUtils.getRandom();
+ TopItems.Estimator<Long> estimator = new TopItems.Estimator<Long>() {
+ @Override
+ public double estimate(Long thing) throws TasteException {
+ return random.nextDouble();
+ }
+ };
+ List<RecommendedItem> topItems = TopItems.getTopItems(10, possibleItemIds,
null, estimator);
+ double last = 2;
+ assertEquals(10, topItems.size());
+ for (RecommendedItem topItem : topItems) {
+ assertTrue(topItem.getValue() <= last);
+ last = topItem.getItemID();
+ }
+ }
+
+ @Test
+ public void testTopUsers() throws Exception {
+ long[] ids = new long[100];
+ for (int i = 0; i < 100; i++) {
+ ids[i] = i;
+ }
+ LongPrimitiveIterator possibleItemIds = new
LongPrimitiveArrayIterator(ids);
+ TopItems.Estimator<Long> estimator = new TopItems.Estimator<Long>() {
+ @Override
+ public double estimate(Long thing) throws TasteException {
+ return thing;
+ }
+ };
+ long[] topItems = TopItems.getTopUsers(10, possibleItemIds, null,
estimator);
+ int gold = 99;
+ for (int i = 0; i < topItems.length; i++) {
+ assertEquals(gold--, topItems[i]);
+ }
+ }
+
+ @Test
+ public void testTopItemItem() throws Exception {
+ List<GenericItemSimilarity.ItemItemSimilarity> sims = new
ArrayList<GenericItemSimilarity.ItemItemSimilarity>();
+ for (int i = 0; i < 99; i++) {
+ sims.add(new GenericItemSimilarity.ItemItemSimilarity(i, i + 1, i /
99.0));
+ }
+
+ List<GenericItemSimilarity.ItemItemSimilarity> res =
TopItems.getTopItemItemSimilarities(10, sims.iterator());
+ int gold = 99;
+ for (int i = 0; i < res.size(); i++) {
+ assertEquals(gold--, res.get(i).getItemID2());//the second id should be
equal to 99 to start
+ }
+ }
+
+ @Test
+ public void testTopItemItemAlt() throws Exception {
+ List<GenericItemSimilarity.ItemItemSimilarity> sims = new
ArrayList<GenericItemSimilarity.ItemItemSimilarity>();
+ for (int i = 0; i < 99; i++) {
+ sims.add(new GenericItemSimilarity.ItemItemSimilarity(i, i + 1, 1 - (i /
99.0)));
+ }
+
+ List<GenericItemSimilarity.ItemItemSimilarity> res =
TopItems.getTopItemItemSimilarities(10, sims.iterator());
+ int gold = 0;
+ for (int i = 0; i < res.size(); i++) {
+ assertEquals(gold++, res.get(i).getItemID1());//the second id should be
equal to 99 to start
+ }
+ }
+
+
+ @Test
+ public void testTopUserUser() throws Exception {
+ List<GenericUserSimilarity.UserUserSimilarity> sims = new
ArrayList<GenericUserSimilarity.UserUserSimilarity>();
+ for (int i = 0; i < 99; i++) {
+ sims.add(new GenericUserSimilarity.UserUserSimilarity(i, i + 1, i /
99.0));
+ }
+
+ List<GenericUserSimilarity.UserUserSimilarity> res =
TopItems.getTopUserUserSimilarities(10, sims.iterator());
+ int gold = 99;
+ for (int i = 0; i < res.size(); i++) {
+ assertEquals(gold--, res.get(i).getUserID2());//the second id should be
equal to 99 to start
+ }
+ }
+
+ @Test
+ public void testTopUserUserAlt() throws Exception {
+ List<GenericUserSimilarity.UserUserSimilarity> sims = new
ArrayList<GenericUserSimilarity.UserUserSimilarity>();
+ for (int i = 0; i < 99; i++) {
+ sims.add(new GenericUserSimilarity.UserUserSimilarity(i, i + 1, 1 - (i /
99.0)));
+ }
+
+ List<GenericUserSimilarity.UserUserSimilarity> res =
TopItems.getTopUserUserSimilarities(10, sims.iterator());
+ int gold = 0;
+ for (int i = 0; i < res.size(); i++) {
+ assertEquals(gold++, res.get(i).getUserID1());//the first id should be
equal to 0 to start
+ }
+ }
+}
