svn commit: r1209835 - in /mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb: CachingCVB0Mapper.java TopicModel.java

[jmannix]

Author: jmannix
Date: Sat Dec  3 05:50:44 2011
New Revision: 1209835

URL: http://svn.apache.org/viewvc?rev=1209835&view=rev
Log:
Fix some things findbugs found on Jenkins.

Modified:
    
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java
    
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java

Modified: 
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java
URL: 
http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java?rev=1209835&r1=1209834&r2=1209835&view=diff
==============================================================================
--- 
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java
 (original)
+++ 
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java
 Sat Dec  3 05:50:44 2011
@@ -99,7 +99,7 @@ public class CachingCVB0Mapper
   public void map(IntWritable docId, VectorWritable document, Context context)
       throws IOException, InterruptedException{
     /* where to get docTopics? */
-    Vector topicVector = new DenseVector(new 
double[numTopics]).assign(1/numTopics);
+    Vector topicVector = new DenseVector(new 
double[numTopics]).assign(1.0/numTopics);
     modelTrainer.train(document.get(), topicVector, true, maxIters);
   }
 

Modified: 
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java
URL: 
http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java?rev=1209835&r1=1209834&r2=1209835&view=diff
==============================================================================
--- 
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java
 (original)
+++ 
mahout/trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java
 Sat Dec  3 05:50:44 2011
@@ -39,6 +39,7 @@ import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.Iterator;
@@ -204,7 +205,7 @@ public class TopicModel implements Confi
       }
     }
     if(rows.isEmpty()) {
-      throw new IOException(modelPaths + " have no vectors in it");
+      throw new IOException(Arrays.toString(modelPaths) + " have no vectors in 
it");
     }
     numTopics++;
     Matrix model = new DenseMatrix(numTopics, numTerms);
@@ -216,6 +217,8 @@ public class TopicModel implements Confi
     return Pair.of(model, topicSums);
   }
 
+  // NOTE: this is purely for debug purposes.  It is not performant to 
"toString()" a real model
+  @Override
   public String toString() {
     String buf = "";
     for(int x = 0; x < numTopics; x++) {