Repository: mahout Updated Branches: refs/heads/master 7a3617b33 -> f4631528b
MAHOUT-1935 fix double calculation of XtX closes apache/mahout#277 Project: http://git-wip-us.apache.org/repos/asf/mahout/repo Commit: http://git-wip-us.apache.org/repos/asf/mahout/commit/f4631528 Tree: http://git-wip-us.apache.org/repos/asf/mahout/tree/f4631528 Diff: http://git-wip-us.apache.org/repos/asf/mahout/diff/f4631528 Branch: refs/heads/master Commit: f4631528b6d017d974ed46d191651e1f7edbe6a7 Parents: 7a3617b Author: rawkintrevo <[email protected]> Authored: Mon Feb 6 22:03:29 2017 -0600 Committer: rawkintrevo <[email protected]> Committed: Mon Feb 6 22:03:29 2017 -0600 ---------------------------------------------------------------------- .../math/algorithms/regression/OrdinaryLeastSquaresModel.scala | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mahout/blob/f4631528/math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/OrdinaryLeastSquaresModel.scala ---------------------------------------------------------------------- diff --git a/math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/OrdinaryLeastSquaresModel.scala b/math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/OrdinaryLeastSquaresModel.scala index d59701a..682cf1c 100644 --- a/math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/OrdinaryLeastSquaresModel.scala +++ b/math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/OrdinaryLeastSquaresModel.scala @@ -54,9 +54,8 @@ class OrdinaryLeastSquares[K] extends LinearRegressorFitter[K] { X = X cbind 1 } - val XtX = X.t %*% X - XtX.collect - val drmXtXinv = solve(X.t %*% X) + val XtX = (X.t %*% X).collect + val drmXtXinv = solve(XtX) val drmXty = (X.t %*% drmTarget).collect // this fails when number of columns^2 size matrix won't fit in driver model.beta = (drmXtXinv %*% drmXty)(::, 0)
