Repository: mahout Updated Branches: refs/heads/develop ae8e3bbe6 -> 38cc9e270
MAHOUT-1975 Add GitHub PR Template closes apache/mahout#313 Project: http://git-wip-us.apache.org/repos/asf/mahout/repo Commit: http://git-wip-us.apache.org/repos/asf/mahout/commit/38cc9e27 Tree: http://git-wip-us.apache.org/repos/asf/mahout/tree/38cc9e27 Diff: http://git-wip-us.apache.org/repos/asf/mahout/diff/38cc9e27 Branch: refs/heads/develop Commit: 38cc9e2706e07612cac9b400aac19001253e2fee Parents: ae8e3bb Author: rawkintrevo <[email protected]> Authored: Wed May 3 13:03:21 2017 -0500 Committer: rawkintrevo <[email protected]> Committed: Wed May 3 13:03:21 2017 -0500 ---------------------------------------------------------------------- .github/PULL_REQUEST_TEMPLATE | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mahout/blob/38cc9e27/.github/PULL_REQUEST_TEMPLATE ---------------------------------------------------------------------- diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE new file mode 100644 index 0000000..36963e0 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE @@ -0,0 +1,28 @@ +### Purpose of PR: +Please give a short description of what this PR is for. + + +First, make sure you are opening this PR against the `develop` branch (not master). +Right beneath "Open PR" you will see `base fork: apache/mahout` dropdown, then `master` as a dropdown. Click that and select `develop` (or in some cases the name of the feature-branch you're working on). + +### Important ToDos +Please mark each with an "x" +- [ ] Opening PR against `develop` NOT `master` (OR `feature-name` if this is part of an ongoing feature development). +- [ ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/] +- [ ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX +is the JIRA number. +- [ ] Created unit tests where appropriate +- [ ] Added licenses correct on newly added files +- [ ] Assigned JIRA to self +- [ ] Added documentation in scala docs/java docs, (and website once that +is merged to dev) +- [ ] Successfully built and ran all unit tests, verified that all tests +pass locally. + +If all of these things aren't complete, but you still feel it is +appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the +descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change" + +Oh by the way, does this change break earlier versions? + +Is this the beginning of a larger project for which a feature branch should be made?
