guan404ming commented on code in PR #934:
URL: https://github.com/apache/mahout/pull/934#discussion_r2750487787
##########
qdp/qdp-core/src/lib.rs:
##########
@@ -726,7 +729,9 @@ impl QdpEngine {
{
crate::profile_scope!("GPU::Synchronize");
- sync_cuda_stream(stream, "CUDA stream synchronize
failed")?;
+ self.device
+ .synchronize()
Review Comment:
Inconsistent error message style within the same function. Line 438 uses
`"CUDA device synchronize failed: {:?}"` but here it's `"Sync failed: {:?}"`.
Let's update with consistent format, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
