guan404ming commented on code in PR #1010: URL: https://github.com/apache/mahout/pull/1010#discussion_r2762758510
########## qdp/qdp-python/qumat_qdp/loader.py: ########## Review Comment: I think both _source_type string and three boolean flags track the same information. Maybe we could consider to keep only booleans since this would eliminate ~10 lines of validation logic in `_create_iterator()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
