guan404ming commented on code in PR #1006: URL: https://github.com/apache/mahout/pull/1006#discussion_r2762783276
########## qdp/qdp-core/src/gpu/encodings/amplitude.rs: ########## Review Comment: I think this computes L2 norms (expensive) just to check finiteness (cheap side effect). Maybe we could introduce a dedicated `check_finite_batch` kernel would be more direct. I think we could do it in a follow up and please correct me if I'm wrong. Thanks! cc @rich7420 @ryankert01 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
