ryankert01 commented on code in PR #1143: URL: https://github.com/apache/mahout/pull/1143#discussion_r2901511603
########## testing/conftest.py: ########## @@ -32,25 +32,25 @@ # Check if QDP extension is available at module load time _QDP_AVAILABLE = False -_QDP_IMPORT_ERROR: Optional[str] = "No module named '_qdp'" +_QDP_IMPORT_ERROR: str | None = "No module named '_qdp'" try: - import _qdp # noqa: F401, PLC0415 + import _qdp Review Comment: gotcha! I worked in a much older codebase lately(ray). Seeing `Optional` a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
