0lai0 commented on code in PR #1154: URL: https://github.com/apache/mahout/pull/1154#discussion_r2902099886
########## qdp/qdp-python/benchmark/README.md: ########## @@ -11,12 +11,20 @@ scripts: ## Quick Start -From the repo root: +From the repo root, the easiest way to set up and run benchmarks is: + +```bash +make benchmark +``` + +This will: +1. Set up the benchmark environment in the unified root venv (`mahout/.venv`) +2. Build the QDP extension (if GPU available) +3. Display instructions for running specific benchmarks + +Then run individual benchmarks: ```bash -uv sync --group dev --extra qdp Review Comment: Good catch! Thanks @guan404ming. I found that `setup-benchmark` should include `uv sync --group dev --extra qdp` to ensure the `qumat-qdp` package path is properly registered in the environment, consistent with the development environment setup in DEVELOPMENT.md. I will fix the Makefile to include this, and also restore the manual setup steps in the README as an alternative option. Will push a fix shortly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
