bearomorphism commented on code in PR #1159:
URL: https://github.com/apache/mahout/pull/1159#discussion_r2902118535
##########
pyproject.toml:
##########
@@ -119,7 +123,15 @@ select = [
"PT",
]
-ignore = ["PT011"]
+ignore = [
+ "E402", # Module level import not at top of file
+ "E501", # Line too long
+ # The following ignore rules are temporary and should be removed when the
issues are fixed.
+ "PT011", # TODO: `pytest.raises(ValueError)` is too broad
+ "ANN001", # TODO: fix (missing-type-function-argument)
+ "ANN201", # TODO: fix (missing-return-type-undocumented-public-function)
+ "ANN202", # TODO: fix (missing-return-type-private-function)
Review Comment:
Add return types and parameter types probably? I think we can have some AI
agent figure out most of the types in a separate PR.
I prefer to fix trivial issues first in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
