viiccwen opened a new pull request, #1303:
URL: https://github.com/apache/mahout/pull/1303

   ### Related Issues
   
   Closes #1252
   
   ### Changes
   
   - [x] Bug fix
   - [ ] New feature
   - [ ] Refactoring
   - [x] Documentation
   - [x] Test
   - [ ] CI/CD pipeline
   - [ ] Other
   
   ### Why
   
   `benchmark_latency.py` and `benchmark_throughput.py` allowed non-`amplitude` 
encoding selections while still running competitor paths that only implement 
amplitude-style workloads. That made some CLI combinations misleading: the 
benchmark table looked cross-framework comparable even when only the Mahout leg 
honored the selected encoding.
   
   This PR takes the short-term correctness path from #1252: reject invalid 
non-amplitude framework combinations instead of silently producing mismatched 
comparisons.
   
   ### How
   
   - added a shared benchmark CLI validator for framework/encoding combinations
   - made the latency and throughput CLIs fail fast when a non-`amplitude` 
encoding is requested outside the supported Mahout-only path
   - added CLI-focused regression tests for the helper and `main()` failure 
paths
   - updated benchmark README guidance and examples to match the enforced 
behavior
   - tightened the benchmark CLI test harness so it always imports the local 
benchmark package from this checkout
   
   ## Checklist
   
   - [x] Added or updated unit tests for all changes
   - [x] Added or updated documentation for all changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to