ryankert01 opened a new pull request, #1314:
URL: https://github.com/apache/mahout/pull/1314

   ## Summary
   
   - 
`testing/qdp_python/test_fallback.py::TestLoaderPytorchBackend::test_invalid_backend_raises`
 was asserting an older error message format (`'rust', 'pytorch', or 'auto'`). 
The current implementation in `qdp/qdp-python/qumat_qdp/loader.py:355` raises 
`backend must be one of ['auto', 'pytorch', 'rust'], got 'invalid'` instead, so 
the test was failing whenever it actually ran the assertion path.
   - Update the regex to match the current sorted-list format. Functional 
behavior is unchanged; this is purely a stale-test fix.
   
   ## How it slipped through
   
   The drift is between two validation paths in the package: 
`qumat_qdp/api.py:128` still raises the older `'rust' or 'pytorch'` form, while 
`qumat_qdp/loader.py:355` raises the newer sorted-set form. The test happens to 
exercise the loader path, which had been refactored without the test being 
updated.
   
   ## Test plan
   
   - [ ] CI green
   - [x] Verified locally against the `qumat-qdp 0.2.0rc1` wheel installed from 
TestPyPI: this single test now passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to