Copilot commented on code in PR #1376:
URL: https://github.com/apache/mahout/pull/1376#discussion_r3363905977
##########
.github/workflows/wheel-build.yml:
##########
@@ -61,29 +84,39 @@ jobs:
working-directory: qdp/qdp-python
command: build
target: x86_64
- args: --release --out dist --interpreter python${{
matrix.python-version }}
+ args: --release --out dist -i python3.10 -i python3.11 -i python3.12
manylinux: 2_28
before-script-linux: |
+ CUDA_VER=12.5
+ CUDA_PKG_VER=12-5
# Install gcc 13 (CUDA 12.5 requires gcc <= 13)
dnf install -y gcc-toolset-13-gcc gcc-toolset-13-gcc-c++
export CC=/opt/rh/gcc-toolset-13/root/usr/bin/gcc
export CXX=/opt/rh/gcc-toolset-13/root/usr/bin/g++
- # Try to install the CUDA 12.5 toolkit for kernel compilation.
- # If the external NVIDIA repo is temporarily unavailable, fall back
- # to a no-CUDA smoke build instead of failing the PR wheel job.
+ # Install the CUDA toolkit for kernel compilation. No fallback:
+ # a wheel that did not compile real CUDA kernels must never
+ # pass this job.
dnf install -y 'dnf-command(config-manager)'
- if dnf config-manager --add-repo
https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/cuda-rhel8.repo
\
- && dnf install -y cuda-nvcc-12-5 cuda-cudart-devel-12-5; then
- export CUDA_PATH=/usr/local/cuda-12.5
- export PATH=/usr/local/cuda-12.5/bin:$PATH
- nvcc --version
- else
- echo "CUDA repo unavailable; continuing with QDP_NO_CUDA=1 smoke
build."
- export QDP_NO_CUDA=1
- fi
+ dnf config-manager --add-repo
https://developer.download.nvidia.com/compute/cuda/repos/rhel8/x86_64/cuda-rhel8.repo
+ dnf install -y cuda-nvcc-${CUDA_PKG_VER}
cuda-cudart-devel-${CUDA_PKG_VER}
+ export CUDA_PATH=/usr/local/cuda-${CUDA_VER}
+ export PATH=/usr/local/cuda-${CUDA_VER}/bin:$PATH
+ nvcc --version
sccache: true
+ - name: Validate and smoke-test wheels
+ working-directory: qdp/qdp-python
+ run: |
Review Comment:
The smoke-test loop creates venvs for Python 3.10/3.11/3.12, but this job
never installs those interpreter versions on the ubuntu runner. On
ubuntu-latest, `uv venv --python "3.10"` / `--python "3.11"` may fail if those
interpreters aren’t preinstalled, making the workflow flaky. Install the
required Python versions (similar to release.yml) before running the loop, so
the venv creation is deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
