rich7420 commented on code in PR #1393:
URL: https://github.com/apache/mahout/pull/1393#discussion_r3380622537
##########
qdp/qdp-core/src/reader.rs:
##########
@@ -96,6 +96,34 @@ pub fn handle_float64_nulls(
Ok(())
}
+/// Append values from a `Float32Array` into `output`, applying the given null
policy.
+///
+/// When there are no nulls the fast path copies the underlying buffer
directly.
+pub fn handle_float32_nulls(
Review Comment:
`handle_float32_nulls` is a verbatim copy of `handle_float64_nulls` (only
the type + the `32`/`64` literal differ). Could be one generic
`handle_primitive_nulls<T: ArrowPrimitiveType>` with `T::Native: Default` (use
`unwrap_or_default()`), keeping these two as thin wrappers for the public API.
This one is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
