jeffdaily commented on code in PR #1399:
URL: https://github.com/apache/mahout/pull/1399#discussion_r3397737008
##########
qdp/qdp-kernels/Cargo.toml:
##########
@@ -4,11 +4,18 @@ version.workspace = true
edition.workspace = true
[dependencies]
-cudarc = { workspace = true }
+cudarc = { workspace = true, optional = true }
[build-dependencies]
cc = { workspace = true }
+[features]
+# Default build: NVIDIA CUDA via cudarc + nvcc-compiled kernels.
+default = ["cuda"]
+cuda = ["dep:cudarc"]
+# AMD build: hipcc-compiled kernels + the in-crate HIP device traits; no
cudarc.
+hip = []
Review Comment:
Added in dbee1e1 -- a note in both qdp-kernels and qdp-core `[features]`
that `cuda` and `hip` are mutually exclusive and `hip` takes precedence
(kernels build for HIP; cudarc is compiled but unused).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
