aloha1357 commented on PR #1387:
URL: https://github.com/apache/mahout/pull/1387#issuecomment-4860313969
Thanks, that makes sense. I agree that merging a
scaffolding-only PR into `main` is not the right direction.
I reworked this branch following the “big PR” approach you
suggested, so this is no longer just TC scaffolding. The
branch now contains the complete remediation for the TC path
review issues.
What changed:
- Removed the unused `AdaptiveOzakiEngine` path entirely:
- deleted `AdaptiveOzaki.cu`
- deleted `AdaptiveOzaki.h`
- removed `AdaptiveOzaki.cu` from `build.rs`
- removed the unused `launch_adaptive_ozaki_gemm` FFI
declaration and non-CUDA stub
- Extracted only the shared Ozaki config types needed by
`ImplicitHadamardOzakiEngine` into `ozaki_config.h`.
- Fixed the TC launcher error handling:
- `cudaFuncSetAttribute` return value is now checked
- the `N <= 12` path now calls
`cudaStreamSynchronize(stream)` before the final
`cudaGetLastError()`
- the larger path continues to use checked CUDA calls
- Fixed the Full-ZZ sample data issue:
- TC data length now accounts for ZZ parameters instead of
assuming `data_len = num_qubits`
- Added direct TC-path tests:
- tests now call `encode_batch_tc`
- deterministic seeds: `42` and `137`
- added independent CPU formula oracle
`torch_iqp_encode_ref`
- small-N checks: `N = 6, 8, 10, 12`, `max_err < 1e-9`
- large-N checks: `N = 14, 16`, `max_err < 1e-5`
- existing TC smoke/agreement tests are preserved and now
use deterministic inputs
Validation run locally in the repo WSL environment:
```text
cargo build -p qdp-kernels
cargo test -p qdp-kernels -q
cargo clippy -p qdp-kernels -- -D warnings
pytest testing/qdp/test_iqp_tc_path.py -v
pytest testing/qdp/test_iqp_tc_path.py -q
pytest testing/qdp/test_bindings.py -q
pytest testing/qdp/ -q
ruff check qdp/
ty check qdp/
Results:
pytest testing/qdp/test_iqp_tc_path.py -v: 25 passed
pytest testing/qdp/test_bindings.py -q: 80 passed, 2 skipped
pytest testing/qdp/ -q: 165 passed, 2 skipped
ruff check qdp/: passed
ty check qdp/: passed
cargo build/test/clippy: passed
So the branch is now intended to be reviewed as the complete
TC-path PR, not as scaffolding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
