rich7420 commented on PR #1445: URL: https://github.com/apache/mahout/pull/1445#issuecomment-5225119364
This bump can't be merged as-is. `pyproject.toml`'s torch range already permits 2.13.0, so this is valid Python-side, but `qdp/Cargo.toml` pins `tch = "0.22"`, whose `torch-sys` build script hard-checks for PyTorch 2.9.0 exactly. `test (3.10)` fails at build: `this tch version expects PyTorch 2.9.0, got 2.13.0`. tch-rs's latest crates.io release is `0.24.0` (PyTorch 2.11 support) — `0.25.0` is listed on the GitHub changelog but not yet published to crates.io, so 2.13 support isn't available as a Cargo dependency yet. #1461 already bumps `tch` to `0.24` and pins `torch==2.11.0` to match, and has just been rebased onto latest main with build/test/clippy verified locally (torch 2.11.0 + tch 0.24.0, `cargo test -p qdp-core --features pytorch --lib`: 100/100 pass). Once #1461 merges, this Dependabot PR should be closed as superseded -- until tch-rs publishes 2.13 support to crates.io, bumping past 2.11.0 will keep breaking `test (3.10)` the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
