rich7420 commented on PR #1461: URL: https://github.com/apache/mahout/pull/1461#issuecomment-5225235028
One more note beyond the inline comment above: this branch is now behind `main` (which has merged #1454/#1456/#1457 since this PR was opened) and will need a rebase before merging. I verified the fix itself works once rebased: `tch = "0.24"` + `torch==2.11.0` builds and passes `cargo test -p qdp-core --features pytorch --lib` (100/100) and `cargo clippy --features pytorch -- -D warnings` cleanly on top of latest main. Also relevant: #1445 (Dependabot, torch->2.13.0) can't be merged -- tch-rs's latest crates.io release (0.24.0) only supports up to PyTorch 2.11, so once this PR lands, #1445 should be closed as superseded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
