ryankert01 opened a new pull request, #1481: URL: https://github.com/apache/mahout/pull/1481
### Related Issues Part of #1477 (4/5). Builds on #1480: this PR's diff against `main` includes that PR's commits; review the last commit only, or diff against `qdp-one-path/3-encode-path`. ### Changes - [x] Refactoring ### Why After 3/5 every encoder launches through the registry, so the transitional host launchers, `extern "C"` declarations and no-CUDA stubs have no callers. ### How - Removes the 26 host launchers from the `.cu` files, the extern block and 26 stubs from `qdp-kernels/src/lib.rs` (now 57 lines), the static nvcc compile from `build.rs`, the `cc` build dependency and the `qdp_no_cuda` cfg in this crate. Kernel sources are device code only (2,633 → 1,434 lines). - Replaces the launcher-level tests with `tests/kernels_numeric.rs`, which launches representative kernels directly through the registry and checks arithmetic: single-sample scaling and padding, the batch norm reduction on odd lengths, the finalize flag, the misaligned odd-sample-length batch path, angle product states, and the finite check. Risk: drops the `staticlib` crate type from `qdp-kernels`; nothing in the workspace links it statically. ## Checklist - [x] Added or updated unit tests for all changes - [x] Added or updated documentation for all changes --- Part of a five-PR series from the same branch, each adding one commit on top of the previous; the diff shown is cumulative against `main`. Series: #1478 → #1479 → #1480 → this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
