Howardisme opened a new pull request, #1503:
URL: https://github.com/apache/mahout/pull/1503

   ### Related Issues
   
   Closes #1471
   
   ### Changes
   
   - [ ] Bug fix
   - [ ] New feature
   - [ ] Refactoring
   - [x] Documentation
   - [ ] Test
   - [ ] CI/CD pipeline
   - [ ] Other
   
   ### Why
   
   The public API doc for `run_throughput_pipeline_py` still listed the removed 
boolean flag `float32_pipeline=False`. 
   When following the docs (`run_throughput_pipeline_py(..., 
float32_pipeline=True)`), it raises `TypeError: got an unexpected keyword 
argument 'float32_pipeline'`, because the native function takes `dtype` instead.
   (The parameter was redesigned from a `bool float32_pipeline` into a `dtype: 
&str` (`"f32"`/`"f64"`) enum in #1276.)
   
   ### How
   
   Update the documented signature from `float32_pipeline=False` to 
`dtype="f64"` (matching `qdp/qdp-python/src/lib.rs`), plus a one-line note on 
the accepted `"f64"`/`"f32"` values. 
   Docs-only; no behavior change.
   
   ## Checklist
   
   - [ ] Added or updated unit tests for all changes
   - [x] Added or updated documentation for all changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to