400Ping opened a new pull request, #1530:
URL: https://github.com/apache/mahout/pull/1530
## Why
One approving review is not enough assurance for merging, in particular for
auto-merge, where nobody looks at the PR again before it lands. The PR policy
already asks for two committer approvals on high-impact changes; this makes
two
approvals the enforced rule for every non-PMC PR.
## What
- `check_pr_approval.py`: counts distinct committer approvers and requires at
least `REQUIRED_APPROVALS` (new `--required-approvals` flag / env, default
2).
PMC-authored PRs stay exempt; review semantics unchanged (latest decisive
review per reviewer, "Request changes"/dismissal revokes).
- `pr-approval-check.yml`: sets `REQUIRED_APPROVALS: "2"`.
- Docs and `.asf.yaml` comments updated.
Since `Committer approval` is a required status check, this applies to
auto-merge and manual merges alike. PMC members keep the ruleset bypass for
emergencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
