Author: kwright
Date: Thu Jan  9 22:31:23 2014
New Revision: 1556972

URL: http://svn.apache.org/r1556972
Log:
Fix for CONNECTORS-854.

Modified:
    manifoldcf/trunk/CHANGES.txt
    
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/jira/JiraSession.java
    
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/jira/JiraSession.java
    
manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
    
manifoldcf/trunk/connectors/meridio/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/meridio/meridiowrapper/MeridioWrapper.java
    
manifoldcf/trunk/connectors/rss/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/rss/ThrottledFetcher.java
    
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/sharepoint/SharePointAuthority.java
    
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/sharepoint/SharePointRepository.java
    
manifoldcf/trunk/connectors/webcrawler/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/webcrawler/ThrottledFetcher.java
    
manifoldcf/trunk/connectors/wiki/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/wiki/WikiConnector.java

Modified: manifoldcf/trunk/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/CHANGES.txt?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- manifoldcf/trunk/CHANGES.txt (original)
+++ manifoldcf/trunk/CHANGES.txt Thu Jan  9 22:31:23 2014
@@ -3,9 +3,16 @@ $Id$
 
 ======================= 1.5-dev =====================
 
+CONNECTORS-854: Enable stale connection checks on all http fetches.
+Not sure why it was disabled long ago, but it causes problems when
+connections are pooled for longer than the server wants the connection
+to survive.
+(Shinichiro Abe, Karl Wright)
+
 CONNECTORS-855: Use -D switch in start-webapps scripts to point
 to the right properties.xml file.  Otherwise who knows where the
 properties may come from.
+(David Morana, Karl Wright)
 
 CONNECTORS-851: Add mail.jar to connector wsdl builder to turn off
 warnings.  Also provide ability to extend build with optional include.

Modified: 
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/jira/JiraSession.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/jira/JiraSession.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/jira/JiraSession.java
 (original)
+++ 
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/jira/JiraSession.java
 Thu Jan  9 22:31:23 2014
@@ -126,7 +126,7 @@ public class JiraSession {
     params.setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE,true);
     params.setIntParameter(CoreProtocolPNames.WAIT_FOR_CONTINUE,socketTimeout);
     params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-    
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+    
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
     
params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,connectionTimeout);
     params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,socketTimeout);
     params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);

Modified: 
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/jira/JiraSession.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/jira/JiraSession.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/jira/JiraSession.java
 (original)
+++ 
manifoldcf/trunk/connectors/jira/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/jira/JiraSession.java
 Thu Jan  9 22:31:23 2014
@@ -126,7 +126,7 @@ public class JiraSession {
     params.setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE,true);
     params.setIntParameter(CoreProtocolPNames.WAIT_FOR_CONTINUE,socketTimeout);
     params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-    
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+    
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
     
params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,connectionTimeout);
     params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,socketTimeout);
     params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);

Modified: 
manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
 (original)
+++ 
manifoldcf/trunk/connectors/livelink/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/livelink/LivelinkConnector.java
 Thu Jan  9 22:31:23 2014
@@ -494,7 +494,7 @@ public class LivelinkConnector extends o
       // Create the httpclient
       BasicHttpParams params = new BasicHttpParams();
       params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
       params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);
       params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,900000);
       params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,300000);

Modified: 
manifoldcf/trunk/connectors/meridio/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/meridio/meridiowrapper/MeridioWrapper.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/meridio/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/meridio/meridiowrapper/MeridioWrapper.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/meridio/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/meridio/meridiowrapper/MeridioWrapper.java
 (original)
+++ 
manifoldcf/trunk/connectors/meridio/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/meridio/meridiowrapper/MeridioWrapper.java
 Thu Jan  9 22:31:23 2014
@@ -260,7 +260,7 @@ public class MeridioWrapper
     // dmws first
     BasicHttpParams dmwsParams = new BasicHttpParams();
     dmwsParams.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-    
dmwsParams.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+    
dmwsParams.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
     dmwsParams.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,60000);
     dmwsParams.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,900000);
     dmwsParams.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);
@@ -305,7 +305,7 @@ public class MeridioWrapper
     // rmws
     BasicHttpParams rmwsParams = new BasicHttpParams();
     rmwsParams.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-    
rmwsParams.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+    
rmwsParams.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
     rmwsParams.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,60000);
     rmwsParams.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,900000);
     rmwsParams.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);
@@ -352,7 +352,7 @@ public class MeridioWrapper
     {
       BasicHttpParams mcwsParams = new BasicHttpParams();
       mcwsParams.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-      
mcwsParams.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+      
mcwsParams.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
       
mcwsParams.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,60000);
       mcwsParams.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,900000);
       
mcwsParams.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);

Modified: 
manifoldcf/trunk/connectors/rss/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/rss/ThrottledFetcher.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/rss/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/rss/ThrottledFetcher.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/rss/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/rss/ThrottledFetcher.java
 (original)
+++ 
manifoldcf/trunk/connectors/rss/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/rss/ThrottledFetcher.java
 Thu Jan  9 22:31:23 2014
@@ -266,7 +266,7 @@ public class ThrottledFetcher
 
       BasicHttpParams params = new BasicHttpParams();
       params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
       
params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,connectionTimeoutMilliseconds);
       
params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,connectionTimeoutMilliseconds);
       params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);

Modified: 
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/sharepoint/SharePointAuthority.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/sharepoint/SharePointAuthority.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/sharepoint/SharePointAuthority.java
 (original)
+++ 
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/authorities/authorities/sharepoint/SharePointAuthority.java
 Thu Jan  9 22:31:23 2014
@@ -703,7 +703,7 @@ public class SharePointAuthority extends
 
       BasicHttpParams params = new BasicHttpParams();
       params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
       params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,60000);
       params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,900000);
       params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);

Modified: 
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/sharepoint/SharePointRepository.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/sharepoint/SharePointRepository.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/sharepoint/SharePointRepository.java
 (original)
+++ 
manifoldcf/trunk/connectors/sharepoint/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/sharepoint/SharePointRepository.java
 Thu Jan  9 22:31:23 2014
@@ -243,7 +243,7 @@ public class SharePointRepository extend
 
       BasicHttpParams params = new BasicHttpParams();
       params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
       params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,60000);
       params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,900000);
       params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);

Modified: 
manifoldcf/trunk/connectors/webcrawler/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/webcrawler/ThrottledFetcher.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/webcrawler/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/webcrawler/ThrottledFetcher.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/webcrawler/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/webcrawler/ThrottledFetcher.java
 (original)
+++ 
manifoldcf/trunk/connectors/webcrawler/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/webcrawler/ThrottledFetcher.java
 Thu Jan  9 22:31:23 2014
@@ -463,7 +463,7 @@ public class ThrottledFetcher
         BasicHttpParams params = new BasicHttpParams();
         params.setParameter(ClientPNames.DEFAULT_HOST,fetchHost);
         params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-        
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+        
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
         params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);
         // MEDIUM_SECURITY compatibility level not supported in 
HttpComponents.  Try BROWSER_NETSCAPE?
         
HttpClientParams.setCookiePolicy(params,CookiePolicy.BROWSER_COMPATIBILITY);

Modified: 
manifoldcf/trunk/connectors/wiki/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/wiki/WikiConnector.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/connectors/wiki/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/wiki/WikiConnector.java?rev=1556972&r1=1556971&r2=1556972&view=diff
==============================================================================
--- 
manifoldcf/trunk/connectors/wiki/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/wiki/WikiConnector.java
 (original)
+++ 
manifoldcf/trunk/connectors/wiki/connector/src/main/java/org/apache/manifoldcf/crawler/connectors/wiki/WikiConnector.java
 Thu Jan  9 22:31:23 2014
@@ -237,7 +237,7 @@ public class WikiConnector extends org.a
       params.setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE,true);
       
params.setIntParameter(CoreProtocolPNames.WAIT_FOR_CONTINUE,socketTimeout);
       params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY,true);
-      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,false);
+      
params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK,true);
       params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT,socketTimeout);
       
params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT,connectionTimeout);
       params.setBooleanParameter(ClientPNames.ALLOW_CIRCULAR_REDIRECTS,true);


Reply via email to