Author: kwright
Date: Wed Feb 12 08:40:36 2014
New Revision: 1567564

URL: http://svn.apache.org/r1567564
Log:
Add clarifying comments

Modified:
    
manifoldcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/jobs/JobManager.java

Modified: 
manifoldcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/jobs/JobManager.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/jobs/JobManager.java?rev=1567564&r1=1567563&r2=1567564&view=diff
==============================================================================
--- 
manifoldcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/jobs/JobManager.java
 (original)
+++ 
manifoldcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/jobs/JobManager.java
 Wed Feb 12 08:40:36 2014
@@ -7533,6 +7533,8 @@ public class JobManager implements IJobM
   public void finishJobResumes(long timestamp, ArrayList modifiedJobs)
     throws ManifoldCFException
   {
+    // Alternative to using a write lock here: Put this in a transaction, with 
a "FOR UPDATE" on the first query.
+    // I think that still causes way too much locking, though, on some 
databases.
     lockManager.enterWriteLock(jobResumeLock);
     try
     {
@@ -7584,6 +7586,8 @@ public class JobManager implements IJobM
   public void finishJobStops(long timestamp, ArrayList modifiedJobs)
     throws ManifoldCFException
   {
+    // Alternative to using a write lock here: Put this in a transaction, with 
a "FOR UPDATE" on the first query.
+    // I think that still causes way too much locking, though, on some 
databases.
     lockManager.enterWriteLock(jobStopLock);
     try
     {
@@ -7674,6 +7678,8 @@ public class JobManager implements IJobM
   public void resetJobs(long currentTime, ArrayList resetJobs)
     throws ManifoldCFException
   {
+    // Alternative to using a write lock here: Put this in a transaction, with 
a "FOR UPDATE" on the first query.
+    // I think that still causes way too much locking, though, on some 
databases.
     lockManager.enterWriteLock(jobResetLock);
     try
     {


Reply via email to