svn commit: r1626105 - in /manifoldcf/branches/release-1.7-branch: ./ framework/core/src/main/java/org/apache/manifoldcf/core/connectorpool/ framework/core/src/main/java/org/apache/manifoldcf/core/lockmanager/

[kwright]

Author: kwright
Date: Thu Sep 18 23:42:24 2014
New Revision: 1626105

URL: http://svn.apache.org/r1626105
Log:
Pull up fix for CONNECTORS-1038 from dev_1x branch

Modified:
    manifoldcf/branches/release-1.7-branch/   (props changed)
    manifoldcf/branches/release-1.7-branch/CHANGES.txt
    
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/connectorpool/ConnectorPool.java
    
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/lockmanager/ZooKeeperEphemeralNodeObject.java

Propchange: manifoldcf/branches/release-1.7-branch/
------------------------------------------------------------------------------
  Merged /manifoldcf/branches/dev_1x:r1625961
  Merged /manifoldcf/trunk:r1625957

Modified: manifoldcf/branches/release-1.7-branch/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/manifoldcf/branches/release-1.7-branch/CHANGES.txt?rev=1626105&r1=1626104&r2=1626105&view=diff
==============================================================================
--- manifoldcf/branches/release-1.7-branch/CHANGES.txt (original)
+++ manifoldcf/branches/release-1.7-branch/CHANGES.txt Thu Sep 18 23:42:24 2014
@@ -8,6 +8,9 @@ CONNECTORS-1041: Livelink connector shou
 HTTP is selected.
 (Karl Wright)
 
+CONNECTORS-1038: Handle multiple pool closes properly.
+(Karl Wright)
+
 CONNECTORS-1036: Zookeeper service handling also has
 ephemeral nodes which need to be tied to sessions.
 (Karl Wright)

Modified: 
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/connectorpool/ConnectorPool.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/connectorpool/ConnectorPool.java?rev=1626105&r1=1626104&r2=1626105&view=diff
==============================================================================
--- 
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/connectorpool/ConnectorPool.java
 (original)
+++ 
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/connectorpool/ConnectorPool.java
 Thu Sep 18 23:42:24 2014
@@ -729,10 +729,13 @@ public abstract class ConnectorPool<T ex
       flushUnused(threadContext);
       
       // End service activity
-      isAlive = false;
-      notifyAll();
-      ILockManager lockManager = LockManagerFactory.make(threadContext);
-      lockManager.endServiceActivity(serviceTypeName, serviceName);
+      if (isAlive)
+      {
+        isAlive = false;
+        notifyAll();
+        ILockManager lockManager = LockManagerFactory.make(threadContext);
+        lockManager.endServiceActivity(serviceTypeName, serviceName);
+      }
     }
 
   }

Modified: 
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/lockmanager/ZooKeeperEphemeralNodeObject.java
URL: 
http://svn.apache.org/viewvc/manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/lockmanager/ZooKeeperEphemeralNodeObject.java?rev=1626105&r1=1626104&r2=1626105&view=diff
==============================================================================
--- 
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/lockmanager/ZooKeeperEphemeralNodeObject.java
 (original)
+++ 
manifoldcf/branches/release-1.7-branch/framework/core/src/main/java/org/apache/manifoldcf/core/lockmanager/ZooKeeperEphemeralNodeObject.java
 Thu Sep 18 23:42:24 2014
@@ -81,8 +81,9 @@ public class ZooKeeperEphemeralNodeObjec
     throws ManifoldCFException, InterruptedException
   {
     if (currentConnection == null)
+      throw new IllegalStateException("Can't delete node '"+nodePath+"' that 
we don't own");
       // It's allowed to delete the same node multiple times
-      return;
+      //return;
     
     currentConnection.deleteNode();
     pool.release(currentConnection);