fixing our unit-tests (this fails some ldp-testsuite tests): true deletion and uri-reuse need extra attentions (MARMOTTA-527)
Project: http://git-wip-us.apache.org/repos/asf/marmotta/repo Commit: http://git-wip-us.apache.org/repos/asf/marmotta/commit/98a73d16 Tree: http://git-wip-us.apache.org/repos/asf/marmotta/tree/98a73d16 Diff: http://git-wip-us.apache.org/repos/asf/marmotta/diff/98a73d16 Branch: refs/heads/ldp Commit: 98a73d1631df1bb6e72aa1d23c77485e05e3bc2c Parents: 2befd47 Author: Jakob Frank <[email protected]> Authored: Sun Sep 7 16:36:57 2014 +0200 Committer: Jakob Frank <[email protected]> Committed: Sun Sep 7 16:36:57 2014 +0200 ---------------------------------------------------------------------- .../marmotta/platform/ldp/services/LdpServiceImpl.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/marmotta/blob/98a73d16/platform/marmotta-ldp/src/main/java/org/apache/marmotta/platform/ldp/services/LdpServiceImpl.java ---------------------------------------------------------------------- diff --git a/platform/marmotta-ldp/src/main/java/org/apache/marmotta/platform/ldp/services/LdpServiceImpl.java b/platform/marmotta-ldp/src/main/java/org/apache/marmotta/platform/ldp/services/LdpServiceImpl.java index cdb48cc..a001220 100644 --- a/platform/marmotta-ldp/src/main/java/org/apache/marmotta/platform/ldp/services/LdpServiceImpl.java +++ b/platform/marmotta-ldp/src/main/java/org/apache/marmotta/platform/ldp/services/LdpServiceImpl.java @@ -589,8 +589,13 @@ public class LdpServiceImpl implements LdpService { connection.clear(resource); // Sec. 5.2.3.11: LDP servers that allow member creation via POST should not re-use URIs. - connection.add(resource, RDF.TYPE, LDP.Resource, ldpContext); - //TODO: keep the track if was there work, but is a good idea? + /* FIXME: the following statement makes problems: + * including this line breakes true deletions of resources (fails our unit-tests) + * removing this line allows re-use of uris and thus fails the ldp-testsuite + * --> maybe use a different namespace? Add a 'deleted' marker and send 410 'Gone' responses? + */ + //connection.add(resource, RDF.TYPE, LDP.Resource, ldpContext); + // TODO: keep the track if was there work, but is a good idea? return true; }
