svn commit: r389014 - in /maven/plugins/trunk/maven-checkstyle-plugin: pom.xml src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java

[epunzalan]

Author: epunzalan
Date: Sun Mar 26 19:47:25 2006
New Revision: 389014

URL: http://svn.apache.org/viewcvs?rev=389014&view=rev
Log:
Removed doxiaHack methods after MNG-1744 fix. Added prerequisite in pom.xml

Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/pom.xml
    
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java

Modified: maven/plugins/trunk/maven-checkstyle-plugin/pom.xml
URL: 
http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-checkstyle-plugin/pom.xml?rev=389014&r1=389013&r2=389014&view=diff
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/pom.xml (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/pom.xml Sun Mar 26 19:47:25 2006
@@ -5,6 +5,9 @@
     <version>1</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
+  <prerequisites>
+    <maven>2.0.2</maven>
+  </prerequisites>
   <artifactId>maven-checkstyle-plugin</artifactId>
   <packaging>maven-plugin</packaging>
   <name>Maven Checkstyle Plugin</name>

Modified: 
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
URL: 
http://svn.apache.org/viewcvs/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java?rev=389014&r1=389013&r2=389014&view=diff
==============================================================================
--- 
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
 (original)
+++ 
maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
 Sun Mar 26 19:47:25 2006
@@ -142,8 +142,6 @@
         sink.text( getTitle() );
         sink.sectionTitle1_();
 
-        doxiaHack();
-
         sink.paragraph();
         sink.text( bundle.getString( "report.checkstyle.checkstylelink" ) + " 
" );
         sink.link( "http://checkstyle.sourceforge.net/"; );
@@ -165,7 +163,6 @@
         }
 
         sink.paragraph_();
-        doxiaHack();
     }
 
     private void iconSeverity( String level )
@@ -239,7 +236,6 @@
         sink.sectionTitle1();
         sink.text( bundle.getString( "report.checkstyle.rules" ) );
         sink.sectionTitle1_();
-        doxiaHack();
 
         sink.table();
 
@@ -274,7 +270,6 @@
         sink.table_();
 
         sink.section1_();
-        doxiaHack();
     }
 
     private void doRuleChildren( Configuration configChildren[], 
CheckstyleResults results )
@@ -346,7 +341,6 @@
                     sink.monospaced_();
                 }
                 sink.listItem_();
-                doxiaHack();
             }
             sink.list_();
         }
@@ -366,7 +360,6 @@
         sink.tableCell_();
 
         sink.tableRow_();
-        doxiaHack();
     }
 
     /**
@@ -451,8 +444,6 @@
         sink.text( bundle.getString( "report.checkstyle.summary" ) );
         sink.sectionTitle1_();
 
-        doxiaHack();
-
         sink.table();
 
         sink.tableRow();
@@ -497,7 +488,6 @@
         sink.table_();
 
         sink.section1_();
-        doxiaHack();
     }
 
     private void doFilesSummary( CheckstyleResults results )
@@ -561,7 +551,6 @@
             sink.tableCell_();
 
             sink.tableRow_();
-            doxiaHack();
         }
 
         sink.table_();
@@ -589,7 +578,6 @@
                 continue;
             }
 
-            doxiaHack();
             sink.section2();
             sink.sectionTitle2();
             sink.anchor( file.replace( '/', '.' ) );
@@ -673,7 +661,6 @@
             sink.tableCell_();
 
             sink.tableRow_();
-            doxiaHack();
         }
     }
 
@@ -755,21 +742,5 @@
     public void setCheckstyleModuleFactory( ModuleFactory 
checkstyleModuleFactory )
     {
         this.checkstyleModuleFactory = checkstyleModuleFactory;
-    }
-
-    /**
-     * This is here purely as a hack against the large lines the XhtmlSink
-     * produces.
-     * <p/>
-     * On a large report, this causes the report output to end prematurely.
-     * <p/>
-     * Doxia needs to be fixed. See MNG-1744 for details.
-     *
-     * @deprecated Remove when Doxia's XhtmlSink and MNG-1744 are fixed.
-     */
-    private void doxiaHack()
-    {
-        sink.rawText( EOL );
-        sink.flush();
     }
 }