Author: dennisl
Date: Sun Jul 16 11:54:49 2006
New Revision: 422497

URL: http://svn.apache.org/viewvc?rev=422497&view=rev
Log:
Fix errors reported by Checkstyle

Modified:
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMailMojo.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMojo.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncement.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementDownloader.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementParser.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/mailsender/ProjectJavamailMailSender.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesMojo.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesReportGenerator.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesXML.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/Release.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraDownloader2.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraHelper.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraReportGenerator.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraXML.java
    
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/resource/loader/ProjectResourceLoader.java
    
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ActionTest.java
    
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ReleaseTest.java
    
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/jira/JiraIssueTest.java

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMailMojo.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMailMojo.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMailMojo.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMailMojo.java
 Sun Jul 16 11:54:49 2006
@@ -144,29 +144,29 @@
         mailer.setSmtpPort( getSmtpPort() );
         
         mailer.setSslMode( sslMode );
-        
-        if( username != null )
+
+        if ( username != null )
         {
             mailer.setUsername( username );
         }
-        
-        if( password != null )
+
+        if ( password != null )
         {
             mailer.setPassword( password );
         }
         mailer.initialize();
-        
-        if( isTextFileExisting( template ) )
+
+        if ( isTextFileExisting( template ) )
         {  
             getLog().info( "Connecting to Host: " + getSmtpHost() + ":" + 
getSmtpPort() );
 
             sendMessage(  );
         }
         else
-        {               
-            if( template != null )
+        {
+            if ( template != null )
             {
-                if( isTextFileExisting( template ) )
+                if ( isTextFileExisting( template ) )
                 {
                     getLog().info( "Connecting to Host: " + getSmtpHost() + " 
: " + getSmtpPort() );
 
@@ -195,28 +195,29 @@
         
         try
         {
-            int i=0;
-            
+            int i = 0;
+
             String[] from = getFirstDevInfo( getFrom() );
-            
-            while( i < getToAddresses().size() )
+
+            while ( i < getToAddresses().size() )
             {   
                 email = getToAddresses().get( i ).toString();
 
                 getLog().info( "Sending mail... " + email );
 
-                mailer.send( getSubject(), IOUtil.toString( readAnnouncement( 
template ) ), email, "", from[0], from[1] );
+                mailer.send( getSubject(), IOUtil.toString( readAnnouncement( 
template ) ),
+                             email, "", from[0], from[1] );
+
+                getLog().info( "Sent..." );
 
-                getLog().info("Sent...");                
-                
                 i++;
             }      
         }
-        catch( IOException ioe )
+        catch ( IOException ioe )
         {
             throw new MojoExecutionException( "Failed to send email.", ioe );
         }
-        catch( MailSenderException e )
+        catch ( MailSenderException e )
         {
             throw new MojoExecutionException( "Failed to send email < " + 
email + " >", e );
         }        
@@ -228,7 +229,7 @@
         
         File f = new File( fileName );
 
-        if( f.exists() )
+        if ( f.exists() )
         {
             found = true;
         }
@@ -250,7 +251,7 @@
             
             fileReader = new FileReader( file );
         }
-        catch( FileNotFoundException fnfe )
+        catch ( FileNotFoundException fnfe )
         {
             throw new MojoExecutionException( "File not found. " + fileName );
         }
@@ -269,8 +270,8 @@
         String fromName = "";
         
         String[] info = new String[2];
-        
-        if( fromNames.size() > 0 )
+
+        if ( fromNames.size() > 0 )
         {
             Developer developer = ( Developer ) fromNames.get( 0 );
 
@@ -284,7 +285,7 @@
             
             getLog().info( "email retrieved. " + fromAddress + " < " + 
fromName + " > " );
 
-            if( fromAddress == null  || fromAddress.equals( "" ) )
+            if ( fromAddress == null || fromAddress.equals( "" ) )
             {
                 throw new MojoExecutionException( "Email address in 
<developers> section is required." );
             }
@@ -305,7 +306,7 @@
         return smtpHost;
     }
 
-    public void setSmtpHost(String smtpHost) 
+    public void setSmtpHost( String smtpHost )
     {
         this.smtpHost = smtpHost;
     }
@@ -315,7 +316,7 @@
         return smtpPort;
     }
 
-    public void setSmtpPort(int smtpPort) 
+    public void setSmtpPort( int smtpPort )
     {
         this.smtpPort = smtpPort;
     }
@@ -325,7 +326,7 @@
         return subject;
     }
 
-    public void setSubject(String subject) 
+    public void setSubject( String subject )
     {
         this.subject = subject;
     }
@@ -335,7 +336,7 @@
         return from;
     }
 
-    public void setFrom(List from) 
+    public void setFrom( List from )
     {
         this.from = from;
     }
@@ -345,7 +346,7 @@
         return project;
     }
 
-    public void setProject(MavenProject project) 
+    public void setProject( MavenProject project )
     {
         this.project = project;
     }
@@ -355,7 +356,7 @@
         return toAddresses;
     }
 
-    public void setToAddresses(List toAddresses) 
+    public void setToAddresses( List toAddresses )
     {
         this.toAddresses = toAddresses;
     }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMojo.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMojo.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMojo.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/AnnouncementMojo.java
 Sun Jul 16 11:54:49 2006
@@ -225,7 +225,7 @@
      */
     public void execute() throws MojoExecutionException
     {
-        if( !generateJiraAnnouncement )
+        if ( !generateJiraAnnouncement )
         {
             setXml( new ChangesXML( getXmlPath(), getLog() ) );
 
@@ -243,7 +243,7 @@
      * @param xml parsed changes.xml
      * @throws MojoExecutionException
      */
-    public void doGenerate(ChangesXML xml) throws MojoExecutionException
+    public void doGenerate( ChangesXML xml ) throws MojoExecutionException
     {
         try
         {
@@ -253,7 +253,7 @@
 
             getLog().info( "Creating announcement file from changes.xml..." );
 
-            if( getIntroduction() == null || getIntroduction().equals( "" ) )
+            if ( getIntroduction() == null || getIntroduction().equals( "" ) )
             {
                 setIntroduction( getUrl() );
             }
@@ -282,15 +282,15 @@
 
             processTemplate( context, getOutputDirectory(), template  );
         }
-        catch( ResourceNotFoundException rnfe )
+        catch ( ResourceNotFoundException rnfe )
         {
             throw new MojoExecutionException( "resource not found." );
         }
-        catch( VelocityException ve )
+        catch ( VelocityException ve )
         {
             throw new MojoExecutionException( ve.toString() );
         }
-        catch( IOException ioe )
+        catch ( IOException ioe )
         {
             throw new MojoExecutionException( ioe.toString() );
         }
@@ -304,7 +304,7 @@
 
             getLog().info( "Creating announcement file from JIRA releases..." 
);
 
-            if( getIntroduction() == null || getIntroduction().equals( "" ) )
+            if ( getIntroduction() == null || getIntroduction().equals( "" ) )
             {
                 setIntroduction( getUrl() );
             }
@@ -333,15 +333,15 @@
 
             processTemplate( context, getOutputDirectory(), template  );
         }
-        catch( ResourceNotFoundException rnfe )
+        catch ( ResourceNotFoundException rnfe )
         {
             throw new MojoExecutionException( "resource not found." );
         }
-        catch( VelocityException ve )
+        catch ( VelocityException ve )
         {
             throw new MojoExecutionException( ve.toString() );
         }
-        catch( IOException ioe )
+        catch ( IOException ioe )
         {
             throw new MojoExecutionException( ioe.toString() );
         }
@@ -362,24 +362,26 @@
 
         // Remove "-SNAPSHOT" from the end, if it's there
         String pomVersion = getVersion();
-        if( pomVersion != null && pomVersion.endsWith( SNAPSHOT_SUFFIX )) {
+        if ( pomVersion != null && pomVersion.endsWith( SNAPSHOT_SUFFIX ) )
+        {
             pomVersion = pomVersion.substring( 0, pomVersion.length() - 
SNAPSHOT_SUFFIX.length() );
         }
 
-        for( int i=0; i<releases.size(); i++ )
+        for ( int i = 0; i < releases.size(); i++ )
         {
-            release = (Release) releases.get(i);
+            release = (Release) releases.get( i );
 
-            if( release.getVersion().equals( pomVersion ) )
+            if ( release.getVersion().equals( pomVersion ) )
             {
                 isFound = true;
                 return release;
             }
         }
 
-        if( isFound == false )
+        if ( !isFound )
         {
-            throw new MojoExecutionException( "Couldn't find the release '" + 
pomVersion + "' among the supplied releases." );
+            throw new MojoExecutionException( "Couldn't find the release '" + 
pomVersion
+                + "' among the supplied releases." );
         }
         return release;
     }
@@ -416,17 +418,17 @@
             
             getLog().info( "File created..." );
         }
-        
-        catch( ResourceNotFoundException rnfe ) 
+
+        catch ( ResourceNotFoundException rnfe )
         {
             throw new ResourceNotFoundException( "Template not found. ( " + 
templateDirectory + "/" + template + " )" );
-        } 
-        catch( VelocityException ve) 
+        }
+        catch ( VelocityException ve )
         {
             throw new VelocityException( ve.toString() );
         }
-   
-        catch( Exception e ) 
+
+        catch ( Exception e )
         {
             throw new MojoExecutionException( e.toString(), e.getCause() );
         }
@@ -456,8 +458,8 @@
             try
             {
                 jiraDownloader.doExecute();
-                
-                if( jiraXMLFile.exists() )
+
+                if ( jiraXMLFile.exists() )
                 {
                     JiraAnnouncementParser jiraParser = new 
JiraAnnouncementParser( jiraXMLFile );
                     
@@ -468,7 +470,7 @@
                     doGenerate( releases );
                 }
             }
-            catch( Exception e )
+            catch ( Exception e )
             {
                 throw new MojoExecutionException( 
                         "Failed to download JIRA Announcement", e );
@@ -483,8 +485,8 @@
     {
         return xmlPath;
     }
-    
-    public void setXmlPath(String xmlPath)
+
+    public void setXmlPath( String xmlPath )
     {
         this.xmlPath = xmlPath;
     }
@@ -493,8 +495,8 @@
     {
         return outputDirectory;
     }
-    
-    public void setOutputDirectory(String outputDirectory) 
+
+    public void setOutputDirectory( String outputDirectory )
     {
         this.outputDirectory = outputDirectory;
     }
@@ -503,8 +505,8 @@
     {
         return groupId;
     }
-    
-    public void setGroupId(String groupId)
+
+    public void setGroupId( String groupId )
     {
         this.groupId = groupId;
     }
@@ -513,8 +515,8 @@
     {
         return artifactId;
     }
-    
-    public void setArtifactId(String artifactId)
+
+    public void setArtifactId( String artifactId )
     {
         this.artifactId = artifactId;
     }
@@ -523,8 +525,8 @@
     {
         return version;
     }
-    
-    public void setVersion(String version)
+
+    public void setVersion( String version )
     {
         this.version = version;
     }
@@ -533,8 +535,8 @@
     {
         return url;
     }
-    
-    public void setUrl(String url) 
+
+    public void setUrl( String url )
     {
         this.url = url;
     }
@@ -543,8 +545,8 @@
     {
         return xml;
     }
-    
-    public void setXml(ChangesXML xml) 
+
+    public void setXml( ChangesXML xml )
     {
         this.xml = xml;
     }
@@ -553,8 +555,8 @@
     {
         return packaging;
     }
-    
-    public void setPackaging(String packaging) 
+
+    public void setPackaging( String packaging )
     {
         this.packaging = packaging;
     }
@@ -563,8 +565,8 @@
     {
         return developmentTeam;
     }
-    
-    public void setDevelopmentTeam(String developmentTeam) 
+
+    public void setDevelopmentTeam( String developmentTeam )
     {
         this.developmentTeam = developmentTeam;
     }
@@ -573,8 +575,8 @@
     {
         return introduction;
     }
-    
-    public void setIntroduction(String introduction) 
+
+    public void setIntroduction( String introduction )
     {
         this.introduction = introduction;
     }
@@ -583,8 +585,8 @@
     {
         return velocity;
     }
-    
-    public void setVelocity(VelocityComponent velocity) 
+
+    public void setVelocity( VelocityComponent velocity )
     {
         this.velocity = velocity;
     }
@@ -593,8 +595,8 @@
     {
         return finalName;
     }
-    
-    public void setFinalName(String finalName) 
+
+    public void setFinalName( String finalName )
     {
         this.finalName = finalName;
     }
@@ -603,8 +605,8 @@
     {
         return urlDownload;
     }
-            
-    public void setUrlDownload(String urlDownload) 
+
+    public void setUrlDownload( String urlDownload )
     {
         this.urlDownload = urlDownload;
     }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncement.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncement.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncement.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncement.java
 Sun Jul 16 11:54:49 2006
@@ -39,11 +39,11 @@
     
     private String reporter;
     
-    List comments;
+    private List comments;
     
     public void addComment( String comment )
     {
-        if( comments == null )
+        if ( comments == null )
         {
             comments = new ArrayList();
         }
@@ -75,7 +75,7 @@
         return title;
     }
 
-    public void setTitle(String title) 
+    public void setTitle( String title )
     {
         this.title = title;
     }    

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementDownloader.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementDownloader.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementDownloader.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementDownloader.java
 Sun Jul 16 11:54:49 2006
@@ -226,9 +226,9 @@
 
             Map urlMap = getJiraUrlAndIssueId();
 
-            String jiraUrl = (String) urlMap.get("url");
+            String jiraUrl = (String) urlMap.get( "url" );
 
-            String jiraId = (String) urlMap.get("id");
+            String jiraId = (String) urlMap.get( "id" );
 
             doAuthentication( cl, jiraUrl );
 
@@ -282,9 +282,9 @@
         }
         getLog().info( "JIRA lives at: " + jiraUrl );
 
-        urlMap.put("url", jiraUrl);
+        urlMap.put( "url", jiraUrl );
 
-        urlMap.put("id", id);
+        urlMap.put( "id", id );
 
         return urlMap;
     }
@@ -304,7 +304,8 @@
 
             Credentials defaultcreds = new UsernamePasswordCredentials( 
webUser, webPassword );
 
-            getLog().info( "Using username: " + webUser + " for Basic 
Authentication against the webserver at " + jiraUrl );
+            getLog().info( "Using username: " + webUser + " for Basic 
Authentication against the webserver at "
+                + jiraUrl );
 
             client.getState().setCredentials( null, null, defaultcreds );
         }
@@ -393,7 +394,7 @@
 
             proxyPass = settings.getActiveProxy().getPassword();
 
-            getLog().info(proxyPass);
+            getLog().info( proxyPass );
         }
 
         if ( proxyHost != null )
@@ -632,7 +633,7 @@
         return log;
     }
 
-    public void setSettings(Settings settings)
+    public void setSettings( Settings settings )
     {
         this.settings = settings;
     }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementParser.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementParser.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementParser.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/JiraAnnouncementParser.java
 Sun Jul 16 11:54:49 2006
@@ -43,7 +43,7 @@
     
     private JiraAnnouncement issue;
     
-    List issues = new ArrayList();
+    private List issues = new ArrayList();
     
     public JiraAnnouncementParser( String xmlPath )
     {
@@ -67,7 +67,7 @@
             
             parser.parse( xml, this );
         }
-        catch( Throwable t )
+        catch ( Throwable t )
         {
             t.printStackTrace();
         }
@@ -76,7 +76,7 @@
     public void startElement( String namespaceURI, String sName, String qName, 
Attributes attrs )
         throws SAXException
     {
-        if( qName.equals( "item" ) )
+        if ( qName.equals( "item" ) )
         {
             issue = new JiraAnnouncement();
             
@@ -87,53 +87,53 @@
     public void endElement( String namespaceURI, String sName, String qName )
         throws SAXException
     {
-        if( qName.equals( "item" ) )
+        if ( qName.equals( "item" ) )
         {
             issues.add( issue ); 
             
             parentElement = "";
         }
-        else if( qName.equals( "title" ) && parentElement.equals( "item" ) )
+        else if ( qName.equals( "title" ) && parentElement.equals( "item" ) )
         {
             issue.setTitle( elementValue );
         }
-        else if( qName.equals( "key" ) )
+        else if ( qName.equals( "key" ) )
         {
             issue.setKey( elementValue );
         }
-        else if( qName.equals( "link" ) && parentElement.equals( "item" ) )
+        else if ( qName.equals( "link" ) && parentElement.equals( "item" ) )
         {
             issue.setLink( elementValue );
         }
-        else if( qName.equals( "summary" ) )
+        else if ( qName.equals( "summary" ) )
         {
             issue.setSummary( elementValue );
         }
-        else if( qName.equals( "type" ) )
+        else if ( qName.equals( "type" ) )
         {
             issue.setType( elementValue );
         }
-        else if( qName.equals( "status" ) )
+        else if ( qName.equals( "status" ) )
         {
             issue.setStatus( elementValue );
         }
-        else if( qName.equals( "resolution" ) )
+        else if ( qName.equals( "resolution" ) )
         {
             issue.setResolution( elementValue );
         }
-        else if( qName.equals( "assignee" ) )
+        else if ( qName.equals( "assignee" ) )
         {
             issue.setAssignee( elementValue );
         }
-        else if( qName.equals( "reporter" ) )
+        else if ( qName.equals( "reporter" ) )
         {
             issue.setReporter( elementValue );
         }
-        else if( qName.equals( "fixVersion" ) )
+        else if ( qName.equals( "fixVersion" ) )
         {
             issue.setFixVersion( elementValue );
         }
-        else if( qName.equals( "comment" ) )
+        else if ( qName.equals( "comment" ) )
         {
             issue.addComment( elementValue );
         }
@@ -145,8 +145,8 @@
         String str = new String( buff, offset, len );
         
         String string = str.trim();
-        
-        if( !string.equals( "" ) )
+
+        if ( !string.equals( "" ) )
         {
             elementValue = string;
         }
@@ -164,8 +164,8 @@
         Release release = new Release();
         
         String type = "";
-        
-        for( int i=0; i<issues.size(); i++ )
+
+        for ( int i = 0; i < issues.size(); i++ )
         {
             JiraAnnouncement issue = ( JiraAnnouncement ) issues.get( i );
             
@@ -173,15 +173,15 @@
             
             action.setIssue( issue.getKey() );
 
-            if( issue.getType().equals( "Bug" ) )
+            if ( issue.getType().equals( "Bug" ) )
             {
                 type = "fix";
             }
-            else if( issue.getType().equals( "New Feature" ) )
+            else if ( issue.getType().equals( "New Feature" ) )
             {
                 type = "add";
             }
-            else if( issue.getType().equals( "Improvement" ) )
+            else if ( issue.getType().equals( "Improvement" ) )
             {
                 type = "update";
             }
@@ -190,8 +190,8 @@
             action.setDev( issue.getAssignee() );
             
             //action.setDueTo( issue.getReporter() );
-            
-            if( issue.getComments() != null && !issue.getComments().isEmpty() )
+
+            if ( issue.getComments() != null && !issue.getComments().isEmpty() 
)
             {
                 int commentSize = issue.getComments().size();
            

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/mailsender/ProjectJavamailMailSender.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/mailsender/ProjectJavamailMailSender.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/mailsender/ProjectJavamailMailSender.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/announcement/mailsender/ProjectJavamailMailSender.java
 Sun Jul 16 11:54:49 2006
@@ -35,8 +35,11 @@
 import java.util.Iterator;
 import java.util.Properties;
 
+/**
+ * Helper class for sending email.
+ */
 public class ProjectJavamailMailSender
-       extends AbstractMailSender
+    extends AbstractMailSender
 {
     private static final String SSL_FACTORY = "javax.net.ssl.SSLSocketFactory";
 
@@ -79,7 +82,7 @@
 
         if ( isSslMode() )
         {
-            Security.addProvider(new com.sun.net.ssl.internal.ssl.Provider());
+            Security.addProvider( new com.sun.net.ssl.internal.ssl.Provider() 
);
 
             props.put( "mail.smtp.socketFactory.port", String.valueOf( 
getSmtpPort() ) );
 
@@ -107,8 +110,8 @@
 
     public void send( MailMessage mail )
         throws MailSenderException
-       {
-           verify( mail );
+    {
+        verify( mail );
 
         try
         {
@@ -125,7 +128,7 @@
                     };
             }
 
-            Session session = Session.getDefaultInstance(props, auth );
+            Session session = Session.getDefaultInstance( props, auth );
 
             session.setDebug( getLogger().isDebugEnabled() );
 
@@ -139,7 +142,7 @@
                 int count = 0;
                 for ( Iterator i = mail.getToAddresses().iterator(); 
i.hasNext(); )
                 {
-                    String address = ((MailMessage.Address) 
i.next()).getRfc2822Address();
+                    String address = ( (MailMessage.Address) i.next() 
).getRfc2822Address();
                     addressTo[count++] = new InternetAddress( address );
                 }
                 msg.setRecipients( Message.RecipientType.TO, addressTo );
@@ -151,7 +154,7 @@
                 int count = 0;
                 for ( Iterator i = mail.getCcAddresses().iterator(); 
i.hasNext(); )
                 {
-                    String address = ((MailMessage.Address) 
i.next()).getRfc2822Address();
+                    String address = ( (MailMessage.Address) i.next() 
).getRfc2822Address();
                     addressCc[count++] = new InternetAddress( address );
                 }
                 msg.setRecipients( Message.RecipientType.CC, addressCc );
@@ -163,7 +166,7 @@
                 int count = 0;
                 for ( Iterator i = mail.getBccAddresses().iterator(); 
i.hasNext(); )
                 {
-                    String address = ((MailMessage.Address) 
i.next()).getRfc2822Address();
+                    String address = ( (MailMessage.Address) i.next() 
).getRfc2822Address();
                     addressBcc[count++] = new InternetAddress( address );
                 }
                 msg.setRecipients( Message.RecipientType.BCC, addressBcc );

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesMojo.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesMojo.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesMojo.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesMojo.java
 Sun Jul 16 11:54:49 2006
@@ -75,7 +75,8 @@
      * &lt;issueManagement&gt;&lt;url&gt; value from the POM, and removing the 
context path. %ISSUE% :
      * this is the issue number.
      * <p>
-     * <strong>Note:</strong> In versions of this plugin prior to 2.0-beta-2 
this parameter was called <code>link_template</code>.
+     * <strong>Note:</strong> In versions of this plugin prior to 2.0-beta-2 
this parameter was called
+     * <code>link_template</code>.
      * </p>
      * 
      * @parameter expression="%URL%/ViewIssue.jspa?key=%ISSUE%"
@@ -98,7 +99,7 @@
     private void copyStaticResources()
         throws MavenReportException
     {
-        final String PLUGIN_RESOURCES_BASE = "org/apache/maven/plugin/changes";
+        final String pluginResourcesBase = "org/apache/maven/plugin/changes";
         String resourceNames[] =
             {"images/add.gif", "images/fix.gif", "images/remove.gif", 
"images/rss.png", "images/update.gif"};
         try
@@ -107,7 +108,7 @@
             for ( int i = 0; i < resourceNames.length; i++ )
             {
                 URL url =
-                    this.getClass().getClassLoader().getResource( 
PLUGIN_RESOURCES_BASE + "/" + resourceNames[i] );
+                    this.getClass().getClassLoader().getResource( 
pluginResourcesBase + "/" + resourceNames[i] );
                 FileUtils.copyURLToFile( url, new File( outputDirectory, 
resourceNames[i] ) );
             }
         }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesReportGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesReportGenerator.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesReportGenerator.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesReportGenerator.java
 Sun Jul 16 11:54:49 2006
@@ -143,7 +143,8 @@
                 {
                     sinkLink( sink, action.getDueTo(), "mailto:"; + 
action.getDueToEmail() );
                 }
-                else {
+                else
+                {
                     sink.text( action.getDueTo() );
                 }
 

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesXML.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesXML.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesXML.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/ChangesXML.java
 Sun Jul 16 11:54:49 2006
@@ -35,15 +35,15 @@
 public class ChangesXML
     extends DefaultHandler
 {
-    Action action;
+    private Action action;
 
-    List actionList;
+    private List actionList;
 
-    Release release;
+    private Release release;
 
-    String currentElement;
+    private String currentElement;
 
-    String currentName;
+    private String currentName;
 
     private List releaseList;
 

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/Release.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/Release.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/Release.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/changes/Release.java
 Sun Jul 16 11:54:49 2006
@@ -50,7 +50,7 @@
     
     public void addAction( Action act )
     {
-        if( action == null )
+        if ( action == null )
         {
             action = new ArrayList();
         }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraDownloader2.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraDownloader2.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraDownloader2.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraDownloader2.java
 Sun Jul 16 11:54:49 2006
@@ -234,9 +234,9 @@
 
             Map urlMap = getJiraUrlAndIssueId();
 
-            String jiraUrl = (String) urlMap.get("url");
+            String jiraUrl = (String) urlMap.get( "url" );
 
-            String jiraId = (String) urlMap.get("id");
+            String jiraId = (String) urlMap.get( "id" );
 
             doAuthentication( cl, jiraUrl );
 
@@ -287,9 +287,9 @@
         }
         getLog().info( "JIRA lives at: " + jiraUrl );
 
-        urlMap.put("url", jiraUrl);
+        urlMap.put( "url", jiraUrl );
 
-        urlMap.put("id", id);
+        urlMap.put( "id", id );
 
         return urlMap;
     }
@@ -309,7 +309,8 @@
 
             Credentials defaultcreds = new UsernamePasswordCredentials( 
webUser, webPassword );
 
-            getLog().info( "Using username: " + webUser + " for Basic 
Authentication against the webserver at " + jiraUrl );
+            getLog().info( "Using username: " + webUser + " for Basic 
Authentication against the webserver at "
+                + jiraUrl );
 
             client.getState().setCredentials( null, null, defaultcreds );
         }
@@ -398,7 +399,7 @@
 
             proxyPass = settings.getActiveProxy().getPassword();
 
-            getLog().info(proxyPass);
+            getLog().info( proxyPass );
         }
 
         if ( proxyHost != null )
@@ -632,8 +633,8 @@
     {
         return log;
     }
-    
-    public void setSettings(Settings settings)
+
+    public void setSettings( Settings settings )
     {
         this.settings = settings;
     }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraHelper.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraHelper.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraHelper.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraHelper.java
 Sun Jul 16 11:54:49 2006
@@ -31,6 +31,8 @@
  */
 public class JiraHelper
 {
+    private static final String PID = "pid=";
+
     /**
      * Try to get a JIRA pid from the issue management URL.
      *
@@ -61,7 +63,7 @@
             }
         }
         String projectPage = gm.getResponseBodyAsString();
-        int pidIndex = projectPage.indexOf( "pid=" );
+        int pidIndex = projectPage.indexOf( PID );
 
         if ( pidIndex == -1 )
         {
@@ -70,7 +72,7 @@
         else
         {
             NumberFormat nf = NumberFormat.getInstance();
-            Number pidNumber = nf.parse( projectPage, new ParsePosition( 
pidIndex + 4 ) );
+            Number pidNumber = nf.parse( projectPage, new ParsePosition( 
pidIndex + PID.length() ) );
             jiraId = Integer.toString( pidNumber.intValue() );
             log.debug( "Found the pid " + jiraId + " at " + issueManagementUrl 
);
         }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraReportGenerator.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraReportGenerator.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraReportGenerator.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraReportGenerator.java
 Sun Jul 16 11:54:49 2006
@@ -28,7 +28,7 @@
  */
 public class JiraReportGenerator
 {
-    JiraXML jira;
+    private JiraXML jira;
 
     public JiraReportGenerator()
     {

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraXML.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraXML.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraXML.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/jira/JiraXML.java
 Sun Jul 16 11:54:49 2006
@@ -36,11 +36,11 @@
 {
     private List issueList;
 
-    String currentElement;
+    private String currentElement;
 
-    String currentParent = "";
+    private String currentParent = "";
 
-    JiraIssue issue;
+    private JiraIssue issue;
 
     public JiraXML( String xmlPath )
     {

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/resource/loader/ProjectResourceLoader.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/resource/loader/ProjectResourceLoader.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/resource/loader/ProjectResourceLoader.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/main/java/org/apache/maven/resource/loader/ProjectResourceLoader.java
 Sun Jul 16 11:54:49 2006
@@ -49,28 +49,28 @@
      */
     private Hashtable templatePaths = new Hashtable();
 
-    public void init( ExtendedProperties configuration)
+    public void init( ExtendedProperties configuration )
     {
-        rsvc.info("ProjectResourceLoader : initialization starting.");
+        rsvc.info( "ProjectResourceLoader : initialization starting." );
 
         String separator = System.getProperty( "file.separator" );
-        
-        String path = System.getProperty( "user.dir" ) + separator + "src" + 
-                separator + "main" + separator + "resources" + separator; 
-        
-        rsvc.info("path :" + path);
+
+        String path = System.getProperty( "user.dir" ) + separator + "src"
+            + separator + "main" + separator + "resources" + separator;
+
+        rsvc.info( "path :" + path );
 
         paths = new Vector();
             
         paths.add( path );
 
         int sz = paths.size();
-  
-        for( int i=0; i < sz; i++)
+
+        for ( int i = 0; i < sz; i++ )
         {
-            rsvc.info("ProjectResourceLoader : adding path '" + (String) 
paths.get(i) + "'");
+            rsvc.info( "ProjectResourceLoader : adding path '" + (String) 
paths.get( i ) + "'" );
         }
-        rsvc.info("ProjectResourceLoader : initialization complete.");
+        rsvc.info( "ProjectResourceLoader : initialization complete." );
     }
 
     /**
@@ -82,13 +82,13 @@
      * @throws ResourceNotFoundException if template not found
      *         in the file template path.
      */
-    public synchronized InputStream getResourceStream(String templateName)
+    public synchronized InputStream getResourceStream( String templateName )
         throws ResourceNotFoundException
     {
         /*
          * Make sure we have a valid templateName.
          */
-        if (templateName == null || templateName.length() == 0)
+        if ( templateName == null || templateName.length() == 0 )
         {
             /*
              * If we don't get a properly formed templateName then
@@ -96,36 +96,36 @@
              * trying to search any more paths for the template.
              */
             throw new ResourceNotFoundException(
-                "Need to specify a file name or file path!");
+                "Need to specify a file name or file path!" );
         }
 
-        String template = StringUtils.normalizePath(templateName);
+        String template = StringUtils.normalizePath( templateName );
         if ( template == null || template.length() == 0 )
         {
-            String msg = "Project Resource loader error : argument " + 
template + 
-                " contains .. and may be trying to access " + 
-                "content outside of template root.  Rejected.";
+            String msg = "Project Resource loader error : argument " + template
+                + " contains .. and may be trying to access "
+                + "content outside of template root.  Rejected.";
 
             rsvc.error( "ProjectResourceLoader : " + msg );
-      
+
             throw new ResourceNotFoundException ( msg );
         }
 
         /*
          *  if a / leads off, then just nip that :)
          */
-        if (template.startsWith("/"))
+        if ( template.startsWith( "/" ) )
         {
-            template = template.substring(1);
+            template = template.substring( 1 );
         }
 
         int size = paths.size();
-        for (int i = 0; i < size; i++)
+        for ( int i = 0; i < size; i++ )
         {
-            String path = (String) paths.get(i);
-            InputStream inputStream = findTemplate(path, template);
-            
-            if (inputStream != null)
+            String path = (String) paths.get( i );
+            InputStream inputStream = findTemplate( path, template );
+
+            if ( inputStream != null )
             {
                 /*
                  * Store the path that this template came
@@ -133,22 +133,22 @@
                  * time.
                  */
 
-                templatePaths.put(templateName, path);
+                templatePaths.put( templateName, path );
                 return inputStream;
-            }                
+            }
         }
-    
+
         /*
          * We have now searched all the paths for
          * templates and we didn't find anything so
          * throw an exception.
          */
-         String msg = "ProjectResourceLoader Error: cannot find resource " +
-          template;
-    
-         throw new ResourceNotFoundException( msg );
+        String msg = "ProjectResourceLoader Error: cannot find resource "
+            + template;
+
+        throw new ResourceNotFoundException( msg );
     }
-    
+
     /**
      * Try to find a template given a normalized path.
      * 
@@ -156,7 +156,7 @@
      * @return InputStream input stream that will be parsed
      *
      */
-    private InputStream findTemplate(String path, String template)
+    private InputStream findTemplate( String path, String template )
     {
         try 
         {
@@ -165,14 +165,14 @@
             if ( file.canRead() )
             {
                 return new BufferedInputStream(
-                    new FileInputStream(file.getAbsolutePath()));
+                    new FileInputStream( file.getAbsolutePath() ) );
             }
             else
             {                
                 return null;
             }                
         }
-        catch( FileNotFoundException fnfe )
+        catch ( FileNotFoundException fnfe )
         {
             /*
              *  log and convert to a general Velocity ResourceNotFoundException
@@ -180,7 +180,7 @@
             return null;
         }
     }
-    
+
     /**
      * How to keep track of all the modified times
      * across the paths.  Note that a file might have
@@ -189,7 +189,7 @@
      * the file we find that way is the same as the one
      * that we have cached.
      */
-    public boolean isSourceModified(Resource resource)
+    public boolean isSourceModified( Resource resource )
     {
         /*
          * we assume that the file needs to be reloaded; 
@@ -199,20 +199,20 @@
         boolean modified = true;
 
         String fileName = resource.getName();
-        String path = (String) templatePaths.get(fileName);
+        String path = (String) templatePaths.get( fileName );
         File currentFile = null;
 
-        for (int i = 0; currentFile == null && i < paths.size(); i++)
+        for ( int i = 0; currentFile == null && i < paths.size(); i++ )
         {
-            String testPath = (String) paths.get(i);
-            File testFile = new File(testPath, fileName);
-            if (testFile.canRead())
+            String testPath = (String) paths.get( i );
+            File testFile = new File( testPath, fileName );
+            if ( testFile.canRead() )
             {
                 currentFile = testFile;
             }
         }
-        File file = new File(path, fileName);
-        if (currentFile == null || !file.exists())
+        File file = new File( path, fileName );
+        if ( currentFile == null || !file.exists() )
         {
             /*
              * noop: if the file is missing now (either the cached
@@ -223,7 +223,7 @@
              * about how the file couldn't be found.
              */
         }
-        else if (currentFile.equals(file) && file.canRead())
+        else if ( currentFile.equals( file ) && file.canRead() )
         {
             /*
              * if only if currentFile is the same as file and
@@ -231,7 +231,7 @@
              * resource.getLastModified(), then we should use the
              * cached version.
              */
-            modified = (file.lastModified() != resource.getLastModified());
+            modified = ( file.lastModified() != resource.getLastModified() );
         }
 
         /*
@@ -240,12 +240,12 @@
         return modified;
     }
 
-    public long getLastModified(Resource resource)
+    public long getLastModified( Resource resource )
     {
-        String path = (String) templatePaths.get(resource.getName());
-        File file = new File(path, resource.getName());
+        String path = (String) templatePaths.get( resource.getName() );
+        File file = new File( path, resource.getName() );
 
-        if (file.canRead())
+        if ( file.canRead() )
         {
             return file.lastModified();
         }            

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ActionTest.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ActionTest.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ActionTest.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ActionTest.java
 Sun Jul 16 11:54:49 2006
@@ -16,15 +16,17 @@
  * limitations under the License.
  */
 
-import junit.framework.*;
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
 
-public class ActionTest extends TestCase {
-    
+public class ActionTest extends TestCase
+{
     Action action = new Action();
-    
-    public ActionTest(String testName) 
+
+    public ActionTest( String testName )
     {
-        super(testName);
+        super( testName );
     }
 
     protected void setUp() throws Exception 
@@ -37,50 +39,50 @@
 
     public static Test suite() 
     {
-        TestSuite suite = new TestSuite(ActionTest.class);
-        
+        TestSuite suite = new TestSuite( ActionTest.class );
+
         return suite;
     }
     
     public void testGetSetAction() 
     {
-        action.setAction("action");
-        
-        assertEquals("action", action.getAction());
+        action.setAction( "action" );
+
+        assertEquals( "action", action.getAction() );
     }
 
     public void testGetSetDev() 
     {
-        action.setDev("developer");
-        
-        assertEquals("developer",action.getDev());
+        action.setDev( "developer" );
+
+        assertEquals( "developer", action.getDev() );
     }
 
     public void testGetSetType() 
     {
-        action.setType("type");
-        
-        assertEquals("type",action.getType());
+        action.setType( "type" );
+
+        assertEquals( "type", action.getType() );
     }
 
     public void testGetSetIssue() 
     {
-        action.setIssue("issue");
-        
-        assertEquals("issue",action.getIssue());
+        action.setIssue( "issue" );
+
+        assertEquals( "issue", action.getIssue() );
     }
 
     public void testGetSetDueTo() 
     {
-        action.setDueTo("due-to");
-        
-        assertEquals("due-to",action.getDueTo());
+        action.setDueTo( "due-to" );
+
+        assertEquals( "due-to", action.getDueTo() );
     }
 
     public void testGetSetDueToEmail() 
     {
-        action.setDueToEmail("due-to-mail");
-        
-        assertEquals("due-to-mail",action.getDueToEmail());
+        action.setDueToEmail( "due-to-mail" );
+
+        assertEquals( "due-to-mail", action.getDueToEmail() );
     }
 }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ReleaseTest.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ReleaseTest.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ReleaseTest.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/changes/ReleaseTest.java
 Sun Jul 16 11:54:49 2006
@@ -16,17 +16,20 @@
  * limitations under the License.
  */
 
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
 import java.util.ArrayList;
-import junit.framework.*;
 import java.util.List;
 
-public class ReleaseTest extends TestCase {
-    
+public class ReleaseTest extends TestCase
+{
     Release release = new Release();
-    
-    public ReleaseTest(String testName) 
+
+    public ReleaseTest( String testName )
     {
-        super(testName);
+        super( testName );
     }
 
     protected void setUp() throws Exception 
@@ -39,32 +42,32 @@
 
     public static Test suite() 
     {
-        TestSuite suite = new TestSuite(ReleaseTest.class);
-        
+        TestSuite suite = new TestSuite( ReleaseTest.class );
+
         return suite;
     }
 
     public void testGetSetVersion() 
     {
-         release.setVersion("version");   
+        release.setVersion( "version" );
 
-         assertEquals("version",release.getVersion());
+        assertEquals( "version", release.getVersion() );
     }
 
     public void testGetSetDateRelease() 
     {
-        release.setDateRelease("12-09-1979");
-        
-        assertEquals("12-09-1979",release.getDateRelease());
+        release.setDateRelease( "12-09-1979" );
+
+        assertEquals( "12-09-1979", release.getDateRelease() );
     }
 
     public void testGetSetAction() 
     {
         List actionList = new ArrayList();
-        
-        release.setAction(actionList);
-        
-        assertEquals(actionList,  release.getAction());
+
+        release.setAction( actionList );
+
+        assertEquals( actionList, release.getAction() );
     }
     
 }

Modified: 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/jira/JiraIssueTest.java
URL: 
http://svn.apache.org/viewvc/maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/jira/JiraIssueTest.java?rev=422497&r1=422496&r2=422497&view=diff
==============================================================================
--- 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/jira/JiraIssueTest.java
 (original)
+++ 
maven/sandbox/plugins/maven-changes-plugin/src/test/java/org/apache/maven/jira/JiraIssueTest.java
 Sun Jul 16 11:54:49 2006
@@ -16,15 +16,17 @@
  * limitations under the License.
  */
 
-import junit.framework.*;
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
 
-public class JiraIssueTest extends TestCase {
-    
+public class JiraIssueTest extends TestCase
+{
     JiraIssue issue;
-    
-    public JiraIssueTest(String testName) 
+
+    public JiraIssueTest( String testName )
     {
-        super(testName);
+        super( testName );
     }
 
     protected void setUp() throws Exception 
@@ -38,44 +40,44 @@
 
     public static Test suite() 
     {
-        TestSuite suite = new TestSuite(JiraIssueTest.class);
-        
+        TestSuite suite = new TestSuite( JiraIssueTest.class );
+
         return suite;
     }
 
     public void testGetSetKey() 
     {
-        issue.setKey("key");
-        
-        assertEquals("key",issue.getKey());
+        issue.setKey( "key" );
+
+        assertEquals( "key", issue.getKey() );
     }
 
     public void testGetSetSummary() 
     {
-        issue.setSummary("summary");
-        
-        assertEquals("summary",issue.getSummary());
+        issue.setSummary( "summary" );
+
+        assertEquals( "summary", issue.getSummary() );
     }
 
     public void testGetSetStatus() 
     {
-        issue.setStatus("status");
-        
-        assertEquals("status",issue.getStatus());
+        issue.setStatus( "status" );
+
+        assertEquals( "status", issue.getStatus() );
     }
 
     public void testGetSetResolution() 
     {
-        issue.setResolution("resolution");
-        
-        assertEquals("resolution",issue.getResolution());
+        issue.setResolution( "resolution" );
+
+        assertEquals( "resolution", issue.getResolution() );
     }
 
     public void testGetSetAssignee() 
     {
-        issue.setAssignee("assignee");
-        
-        assertEquals("assignee",issue.getAssignee());
+        issue.setAssignee( "assignee" );
+
+        assertEquals( "assignee", issue.getAssignee() );
     }
     
 }


Reply via email to