[maven-plugin-testing] branch master updated: [MPLUGINTESTING-76] Upgrade Plexus Archiver from 4.3.0 to 4.6.1 (broken api in 4.4.0) (#29)

[gnodet]

This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-plugin-testing.git


The following commit(s) were added to refs/heads/master by this push:
     new aeabc1d  [MPLUGINTESTING-76] Upgrade Plexus Archiver from 4.3.0 to 
4.6.1 (broken api in 4.4.0) (#29)
aeabc1d is described below

commit aeabc1dfc58d54d7737a8127017dc8c949ef44be
Author: Guillaume Nodet <gno...@apache.org>
AuthorDate: Wed Feb 15 13:39:13 2023 +0100

    [MPLUGINTESTING-76] Upgrade Plexus Archiver from 4.3.0 to 4.6.1 (broken api 
in 4.4.0) (#29)
---
 maven-plugin-testing-harness/pom.xml                           |  2 +-
 .../org/apache/maven/plugin/testing/ArtifactStubFactory.java   | 10 +---------
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/maven-plugin-testing-harness/pom.xml 
b/maven-plugin-testing-harness/pom.xml
index cb222af..7df5ae7 100644
--- a/maven-plugin-testing-harness/pom.xml
+++ b/maven-plugin-testing-harness/pom.xml
@@ -83,7 +83,7 @@ under the License.
     <dependency>
       <groupId>org.codehaus.plexus</groupId>
       <artifactId>plexus-archiver</artifactId>
-      <version>4.3.0</version>
+      <version>4.6.1</version>
     </dependency>
 
     <dependency>
diff --git 
a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ArtifactStubFactory.java
 
b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ArtifactStubFactory.java
index c490845..d510314 100644
--- 
a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ArtifactStubFactory.java
+++ 
b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ArtifactStubFactory.java
@@ -273,17 +273,9 @@ public class ArtifactStubFactory {
         archiver.setDestFile(destFile);
         archiver.addFile(srcFile, getUnpackableFileName(artifact));
 
-        try {
-            setVariableValueToObject(archiver, "logger", new SilentLog());
-        } catch (IllegalAccessException e) {
-            System.out.println("Unable to override logger with silent log.");
-            e.printStackTrace();
-        }
         if (archiver instanceof WarArchiver) {
             WarArchiver war = (WarArchiver) archiver;
-            // the use of this is counter-intuitive:
-            // http://jira.codehaus.org/browse/PLX-286
-            war.setIgnoreWebxml(false);
+            war.setExpectWebXml(false);
         }
         archiver.createArchive();
     }