This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch open-issues
in repository https://gitbox.apache.org/repos/asf/maven-site-plugin.git

commit 660576be0220917a73842913214dc508692065a5
Author: Michael Osipov <[email protected]>
AuthorDate: Sat Apr 15 19:52:21 2023 +0200

    Test for null goal exactly like the caller does to avoid an NPE
---
 .../plugins/site/render/ReportDocumentRenderer.java     | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
 
b/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
index 132ca92f..f0f855e7 100644
--- 
a/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
+++ 
b/src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java
@@ -66,18 +66,15 @@ public class ReportDocumentRenderer implements 
DocumentRenderer {
     public ReportDocumentRenderer(
             MavenReportExecution mavenReportExecution, 
DocumentRenderingContext docRenderingContext, Log log) {
         this.report = mavenReportExecution.getMavenReport();
-
         this.docRenderingContext = docRenderingContext;
-
-        // full MavenReportExecution prepared by maven-reporting-impl
-        this.reportMojoInfo = mavenReportExecution.getPlugin().getArtifactId()
-                + ':'
-                + mavenReportExecution.getPlugin().getVersion()
-                + ':'
-                + mavenReportExecution.getGoal();
-
+        this.reportMojoInfo = mavenReportExecution.getGoal() == null
+                ? null
+                : mavenReportExecution.getPlugin().getArtifactId()
+                        + ':'
+                        + mavenReportExecution.getPlugin().getVersion()
+                        + ':'
+                        + mavenReportExecution.getGoal();
         this.classLoader = mavenReportExecution.getClassLoader();
-
         this.log = log;
     }
 

Reply via email to