[maven-shared-utils] branch master updated: [MSHARED-1014] Make Commandline.addSystemEnvironment public and deprecated

[sjaranowski]

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-utils.git


The following commit(s) were added to refs/heads/master by this push:
     new 462bd11  [MSHARED-1014] Make Commandline.addSystemEnvironment public 
and deprecated
462bd11 is described below

commit 462bd1121b7a7ee9a61ff1ed6a1dbd8fcf2982e0
Author: Slawomir Jaranowski <s.jaranow...@gmail.com>
AuthorDate: Fri Apr 21 20:17:08 2023 +0200

    [MSHARED-1014] Make Commandline.addSystemEnvironment public and deprecated
    
    MavenInvoker still use it.
---
 src/main/java/org/apache/maven/shared/utils/cli/Commandline.java | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java 
b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
index 4f93957..619f5a1 100644
--- a/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
+++ b/src/main/java/org/apache/maven/shared/utils/cli/Commandline.java
@@ -183,8 +183,13 @@ public class Commandline implements Cloneable {
 
     /**
      * Add system environment variables.
+     *
+     * @deprecated please use {@link #setShellEnvironmentInherited(boolean)}
      */
-    private void addSystemEnvironment() {
+    @Deprecated
+    public void addSystemEnvironment() {}
+
+    private void copySystemEnvironment() {
         Properties systemEnvVars = CommandLineUtils.getSystemEnvVars();
 
         for (Object o : systemEnvVars.keySet()) {
@@ -202,7 +207,7 @@ public class Commandline implements Cloneable {
      */
     public String[] getEnvironmentVariables() {
         if (isShellEnvironmentInherited()) {
-            addSystemEnvironment();
+            copySystemEnvironment();
         }
 
         List<String> environmentVars = new ArrayList<>();