[maven-file-management] branch master updated: use JUnit @TempDir (#19)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-file-management.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e31ef4  use JUnit @TempDir (#19)
4e31ef4 is described below

commit 4e31ef448248833cc43f181930eb569ae487cdd7
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Thu Jun 8 08:36:49 2023 -0400

    use JUnit @TempDir (#19)
---
 .../maven/shared/model/fileset/util/FileSetUtilsTest.java    | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git 
a/src/test/java/org/apache/maven/shared/model/fileset/util/FileSetUtilsTest.java
 
b/src/test/java/org/apache/maven/shared/model/fileset/util/FileSetUtilsTest.java
index cbfd101..69dbf3d 100644
--- 
a/src/test/java/org/apache/maven/shared/model/fileset/util/FileSetUtilsTest.java
+++ 
b/src/test/java/org/apache/maven/shared/model/fileset/util/FileSetUtilsTest.java
@@ -31,6 +31,7 @@ import org.codehaus.plexus.util.cli.CommandLineException;
 import org.codehaus.plexus.util.cli.Commandline;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -41,7 +42,8 @@ import static org.junit.jupiter.api.Assertions.fail;
  * Test the FileSet
  */
 public class FileSetUtilsTest {
-    private final Set<File> testDirectories = new HashSet<>();
+    @TempDir
+    File testDirectory;
 
     private final Set<File> linkFiles = new HashSet<>();
 
@@ -51,10 +53,6 @@ public class FileSetUtilsTest {
         for (File linkFile : linkFiles) {
             linkFile.delete();
         }
-
-        for (File dir : testDirectories) {
-            FileUtils.deleteDirectory(dir);
-        }
     }
 
     /**
@@ -302,13 +300,11 @@ public class FileSetUtilsTest {
 
         File sourceDir = new File(URLDecoder.decode(sourceResource.getPath(), 
"UTF-8"));
 
-        String basedir = System.getProperty("basedir", 
System.getProperty("user.dir"));
         String testBase = System.getProperty("testBase", 
"target/test-directories");
 
-        File testDir = new File(basedir, testBase + "/" + directoryName);
+        File testDir = new File(testDirectory, testBase + "/" + directoryName);
         if (testDir.mkdirs()) {
             FileUtils.copyDirectory(sourceDir, testDir);
-            testDirectories.add(testDir);
             return testDir;
         } else {
             throw new IOException("Could not create test directory " + 
testDir);