This is an automated email from the ASF dual-hosted git repository.

henning pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-javadoc-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new 77adc474 [MJAVADOC-642] Make offline mode configurable (#238)
77adc474 is described below

commit 77adc4747e29bbb1873ae812347a77c0e7648565
Author: Henning Schmiedehausen <[email protected]>
AuthorDate: Mon Sep 11 21:54:01 2023 -0700

    [MJAVADOC-642] Make offline mode configurable (#238)
    
    Turns out that `mvn deploy` and `mvn clean deploy` do different things
    with settings. Explicitly add settings to the test-javadoc-test-plugin
    config, otherwise it throws a NPE when running `mvn deploy`.
---
 .../resources/unit/test-javadoc-test/test-javadoc-test-plugin-config.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/src/test/resources/unit/test-javadoc-test/test-javadoc-test-plugin-config.xml 
b/src/test/resources/unit/test-javadoc-test/test-javadoc-test-plugin-config.xml
index 81553297..bf0b5ffa 100644
--- 
a/src/test/resources/unit/test-javadoc-test/test-javadoc-test-plugin-config.xml
+++ 
b/src/test/resources/unit/test-javadoc-test/test-javadoc-test-plugin-config.xml
@@ -55,6 +55,7 @@ under the License.
           <reactorProjects>
             <project 
implementation="org.apache.maven.plugins.javadoc.stubs.TestJavadocMavenProjectStub"/>
           </reactorProjects>
+          <settings implementation="org.apache.maven.settings.Settings"/>
         </configuration>
       </plugin>
     </plugins>

Reply via email to