(maven-shade-plugin) branch master updated: [MSHADE-428] Prevent null value in array of transformers (#229)

[cstamas]

This is an automated email from the ASF dual-hosted git repository.

cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shade-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new ade2e35  [MSHADE-428] Prevent null value in array of transformers 
(#229)
ade2e35 is described below

commit ade2e359214c4094876b0100c97b9a55aecc4c2e
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Tue May 28 14:24:55 2024 +0200

    [MSHADE-428] Prevent null value in array of transformers (#229)
    
    As Plexus will silently add it as explain it in issue.
    This fix merely improves user experience, but not throwing cryptic or 
totally misleading errors.
    
    ---
    
    https://issues.apache.org/jira/browse/MSHADE-428
---
 src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java 
b/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
index 5d171b3..cabc861 100644
--- a/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
+++ b/src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
@@ -915,11 +915,16 @@ public class ShadeMojo extends AbstractMojo {
         return relocators;
     }
 
-    private List<ResourceTransformer> getResourceTransformers() {
+    private List<ResourceTransformer> getResourceTransformers() throws 
MojoExecutionException {
         if (transformers == null) {
             return Collections.emptyList();
         }
-
+        for (ResourceTransformer transformer : transformers) {
+            if (transformer == null) {
+                throw new MojoExecutionException(
+                        "Failed to create shaded artifact: parameter 
transformers contains null (double-check XML attribute)");
+            }
+        }
         return Arrays.asList(transformers);
     }