This is an automated email from the ASF dual-hosted git repository. sjaranowski pushed a commit to branch MSHARED-1401-magic-numner in repository https://gitbox.apache.org/repos/asf/maven-shared-resources.git
commit 68666b636ff9193a3c6d7cab4cfdfd8422933b4a Author: Slawomir Jaranowski <[email protected]> AuthorDate: Sun Jun 2 11:14:47 2024 +0200 [MSHARED-1401] Checkstyle drop MagicNumber more of items are excluded now --- src/main/resources/config/maven_checks.xml | 4 ---- src/main/resources/config/maven_checks_nocodestyle.xml | 4 ---- 2 files changed, 8 deletions(-) diff --git a/src/main/resources/config/maven_checks.xml b/src/main/resources/config/maven_checks.xml index 240f595..04a2810 100644 --- a/src/main/resources/config/maven_checks.xml +++ b/src/main/resources/config/maven_checks.xml @@ -173,10 +173,6 @@ under the License. </module> <module name="IllegalInstantiation"/> <module name="InnerAssignment"/> - <module name="MagicNumber"> - <!-- some numbers are really not that magic --> - <property name="ignoreNumbers" value="-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 31, 32, 37, 64, 100, 128, 256, 512, 1000, 1024"/> - </module> <module name="MissingSwitchDefault"/> <module name="SimplifyBooleanExpression"/> <module name="SimplifyBooleanReturn"/> diff --git a/src/main/resources/config/maven_checks_nocodestyle.xml b/src/main/resources/config/maven_checks_nocodestyle.xml index 70e68e8..39e70ad 100644 --- a/src/main/resources/config/maven_checks_nocodestyle.xml +++ b/src/main/resources/config/maven_checks_nocodestyle.xml @@ -116,10 +116,6 @@ under the License. </module> <module name="IllegalInstantiation"/> <module name="InnerAssignment"/> - <module name="MagicNumber"> - <!-- some numbers are really not that magic --> - <property name="ignoreNumbers" value="-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 31, 32, 37, 64, 100, 128, 256, 512, 1000, 1024"/> - </module> <module name="MissingSwitchDefault"/> <module name="SimplifyBooleanExpression"/> <module name="SimplifyBooleanReturn"/>
