(maven-source-plugin) branch master updated: Us etry with resources to guarantee zip closure (#45)

[elharo]

This is an automated email from the ASF dual-hosted git repository.

elharo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-source-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new a87ec8d  Us etry with resources to guarantee zip closure (#45)
a87ec8d is described below

commit a87ec8de809b412e9723264ada5f744dbc29cb27
Author: Elliotte Rusty Harold <elh...@users.noreply.github.com>
AuthorDate: Tue Dec 24 17:23:59 2024 +0000

    Us etry with resources to guarantee zip closure (#45)
---
 .../source/AbstractSourcePluginTestCase.java       | 27 +++++++++++-----------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git 
a/src/test/java/org/apache/maven/plugins/source/AbstractSourcePluginTestCase.java
 
b/src/test/java/org/apache/maven/plugins/source/AbstractSourcePluginTestCase.java
index 2605fd8..400230c 100644
--- 
a/src/test/java/org/apache/maven/plugins/source/AbstractSourcePluginTestCase.java
+++ 
b/src/test/java/org/apache/maven/plugins/source/AbstractSourcePluginTestCase.java
@@ -67,26 +67,25 @@ public abstract class AbstractSourcePluginTestCase {
     }
 
     protected void assertJarContent(final File jarFile, final String[] 
expectedFiles) throws IOException {
-        ZipFile jar = new ZipFile(jarFile);
-        Enumeration<? extends ZipEntry> entries = jar.entries();
+        try (ZipFile jar = new ZipFile(jarFile)) {
+            Enumeration<? extends ZipEntry> entries = jar.entries();
 
-        if (expectedFiles.length == 0) {
-            assertFalse(entries.hasMoreElements(), "Jar file should not 
contain any entry");
-        } else {
-            assertTrue(entries.hasMoreElements());
+            if (expectedFiles.length == 0) {
+                assertFalse(entries.hasMoreElements(), "Jar file should not 
contain any entry");
+            } else {
+                assertTrue(entries.hasMoreElements());
 
-            Set<String> expected = new TreeSet<>(Arrays.asList(expectedFiles));
+                Set<String> expected = new 
TreeSet<>(Arrays.asList(expectedFiles));
 
-            while (entries.hasMoreElements()) {
-                ZipEntry entry = entries.nextElement();
+                while (entries.hasMoreElements()) {
+                    ZipEntry entry = entries.nextElement();
 
-                assertTrue(expected.remove(entry.getName()), "Not expecting " 
+ entry.getName() + " in " + jarFile);
-            }
+                    assertTrue(expected.remove(entry.getName()), "Not 
expecting " + entry.getName() + " in " + jarFile);
+                }
 
-            assertTrue(expected.isEmpty(), "Missing entries " + expected + " 
in " + jarFile);
+                assertTrue(expected.isEmpty(), "Missing entries " + expected + 
" in " + jarFile);
+            }
         }
-
-        jar.close();
     }
 
     protected File getTestTargetDir(String projectName) {