This is an automated email from the ASF dual-hosted git repository. elharo pushed a commit to branch coll in repository https://gitbox.apache.org/repos/asf/maven.git
commit cebaf19bfd9832d4f88b1cf8412ca545c2130b73 Author: Elliotte Rusty Harold <elh...@ibiblio.org> AuthorDate: Tue Apr 1 06:52:49 2025 -0400 Avoid warning about unthrown exception --- .../java/org/apache/maven/AbstractCoreMavenComponentTestCase.java | 2 +- .../test/java/org/apache/maven/impl/ModelVersionParserTest.java | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/compat/maven-compat/src/test/java/org/apache/maven/AbstractCoreMavenComponentTestCase.java b/compat/maven-compat/src/test/java/org/apache/maven/AbstractCoreMavenComponentTestCase.java index 4364116156..4e3c1042ee 100644 --- a/compat/maven-compat/src/test/java/org/apache/maven/AbstractCoreMavenComponentTestCase.java +++ b/compat/maven-compat/src/test/java/org/apache/maven/AbstractCoreMavenComponentTestCase.java @@ -94,7 +94,7 @@ protected MavenExecutionRequest createMavenExecutionRequest(File pom) throws Exc .setPom(pom) .setProjectPresent(true) .setShowErrors(true) - .setPluginGroups(Arrays.asList("org.apache.maven.plugins")) + .setPluginGroups(List.of("org.apache.maven.plugins")) .setLocalRepository(getLocalRepository()) .setRemoteRepositories(getRemoteRepositories()) .setPluginArtifactRepositories(getPluginArtifactRepositories()) diff --git a/impl/maven-impl/src/test/java/org/apache/maven/impl/ModelVersionParserTest.java b/impl/maven-impl/src/test/java/org/apache/maven/impl/ModelVersionParserTest.java index 0f17cb6fd7..6feffa0ae7 100644 --- a/impl/maven-impl/src/test/java/org/apache/maven/impl/ModelVersionParserTest.java +++ b/impl/maven-impl/src/test/java/org/apache/maven/impl/ModelVersionParserTest.java @@ -24,23 +24,21 @@ import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertNull; import static org.junit.jupiter.api.Assertions.assertTrue; import static org.junit.jupiter.api.Assertions.fail; -/** - */ public class ModelVersionParserTest { private final DefaultModelVersionParser versionParser = new DefaultModelVersionParser(new GenericVersionScheme()); - private VersionParserException parseInvalid(String constraint) { + private void parseInvalid(String constraint) { try { versionParser.parseVersionConstraint(constraint); fail("expected exception for constraint " + constraint); - return null; } catch (VersionParserException e) { - return e; + assertNotNull(e.getMessage()); } }